Attachment 371419 Details for Bug 198551 – Patch

[patch] Patch

bug-198551-20190605103752.patch (text/plain), 1.48 KB, created by Keith Rollin on 2019-06-05 10:37:53 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Keith Rollin

Created: 2019-06-05 10:37:53 PDT

Size: 1.48 KB

patch

obsolete

>Subversion Revision: 246050
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index b5a029e0d599ec2e8a6dee04ea2a691fa24e48cb..cca8075c36cd493769f0dec4669e052eb3fec388 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-06-04  Keith Rollin  <krollin@apple.com>
>+
>+        Remove TestWebKitAPI from some configurations
>+        https://bugs.webkit.org/show_bug.cgi?id=198551
>+        <rdar://problem/51424996>
>+
>+        Don't build TestWebKitAPI on platforms that are missing required SSL
>+        functions.
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Makefile:
>+
> 2019-06-03  Sihui Liu  <sihui_liu@apple.com>
> 
>         [ Mac WK2 ] TestWebKitAPI.WKWebView.LocalStorageProcessCrashes is a flaky timeout when run locally.
>diff --git a/Tools/Makefile b/Tools/Makefile
>index 5d48e7724bfe7878db3b48902b82239d7fabda96..7dc2b48baa2a3b137a9050d9450011a5fb990eea 100644
>--- a/Tools/Makefile
>+++ b/Tools/Makefile
>@@ -3,7 +3,10 @@ MODULES = DumpRenderTree WebKitTestRunner MiniBrowser ../Source/ThirdParty/gtest
> ifneq (,$(SDKROOT))
> 	ifeq (,$(findstring macosx,$(SDKROOT)))
> 		# Embedded OS
>-		MODULES = DumpRenderTree WebKitTestRunner ../Source/ThirdParty/gtest/xcode TestWebKitAPI
>+		MODULES = DumpRenderTree WebKitTestRunner ../Source/ThirdParty/gtest/xcode
>+		ifeq (,$(findstring appletv,$(SDKROOT)))  # Don't build TestWebKitAPI on AppleTV, due to missing SSL support
>+			MODULES += TestWebKitAPI
>+		endif
> 	endif
> 	ifneq (,$(findstring macosx,$(SDKROOT)))
> 		MODULES += lldb/lldbWebKitTester

Actions: View | Formatted Diff | Diff

Attachments on bug 198551: 371362 | 371419 | 371521