Attachment 371412 Details for Bug 198570 – proposed fix

[patch] proposed fix

BlockEmail.txt (text/plain), 1.30 KB, created by Alexey Proskuryakov on 2019-06-05 09:54:12 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Alexey Proskuryakov

Created: 2019-06-05 09:54:12 PDT

Size: 1.30 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 246108)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,13 @@
>+2019-06-05  Alexey Proskuryakov  <ap@apple.com>
>+
>+        block-spammers tool doesn't block e-mail
>+        https://bugs.webkit.org/show_bug.cgi?id=198570
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Scripts/block-spammers: (disable_user): Corrected the parameters, Bugzilla doesn't
>+        recognize "false" here. Also, request body is unnecessary.
>+
> 2019-06-01  Antoine Quint  <graouts@apple.com>
> 
>         [Pointer Events] Add support for chorded button interactions
>Index: Tools/Scripts/block-spammers
>===================================================================
>--- Tools/Scripts/block-spammers	(revision 246086)
>+++ Tools/Scripts/block-spammers	(working copy)
>@@ -85,8 +85,7 @@ def can_use_this_tool():
> 
> def disable_user(user_id, reason):
>     response = requests.put('https://bugs.webkit.org/rest/user/' + str(user_id),
>-        json={'email_enabled': False, 'login_denied_text': reason},
>-        params = {'email_enabled': False, 'login_denied_text': reason, 'token': bugzilla_token})
>+        params = {'email_enabled': 0, 'login_denied_text': reason, 'token': bugzilla_token})
>     response.raise_for_status()
> 
>

Actions: View | Formatted Diff | Diff

Attachments on bug 198570: 371412