Attachment 371396 Details for Bug 198531 – Patch

[patch] Patch

bug-198531-20190605080627.patch (text/plain), 2.76 KB, created by Jon Davis on 2019-06-05 08:06:29 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Jon Davis

Created: 2019-06-05 08:06:29 PDT

Size: 2.76 KB

patch

obsolete

>Subversion Revision: 246106
>diff --git a/Websites/webkit.org/ChangeLog b/Websites/webkit.org/ChangeLog
>index 3f5c6a2995ed3e5fcef53acbd3b0e80345d8ab5a..db7c299922261675da7b7ec531460963b0199c59 100644
>--- a/Websites/webkit.org/ChangeLog
>+++ b/Websites/webkit.org/ChangeLog
>@@ -1,3 +1,13 @@
>+2019-06-05  Jon Davis  <jond@apple.com>
>+
>+        Improve accessibility on webkit.org
>+        https://bugs.webkit.org/show_bug.cgi?id=198531
>+
>+        Reviewed by Devin Rousso.
>+
>+        * wp-content/themes/webkit/functions.php: Added menuitem ARIA role to links
>+        * wp-content/themes/webkit/widgets/post.php: Added aria-label to SVG icons
>+
> 2019-06-04  Jon Davis  <jond@apple.com>
> 
>         Improve performance of the lazy image loader
>diff --git a/Websites/webkit.org/wp-content/themes/webkit/functions.php b/Websites/webkit.org/wp-content/themes/webkit/functions.php
>index 3d249c4616aa7c7d5111423b583d5157b484a05b..f25e03255f7053d842e0ba79c5e7507dea656376 100644
>--- a/Websites/webkit.org/wp-content/themes/webkit/functions.php
>+++ b/Websites/webkit.org/wp-content/themes/webkit/functions.php
>@@ -435,7 +435,7 @@ class Responsive_Toggle_Walker_Nav_Menu extends Walker_Nav_Menu {
>         $atts['target'] = ! empty( $item->target )     ? $item->target     : '';
>         $atts['rel']    = ! empty( $item->xfn )        ? $item->xfn        : '';
>         $atts['href']   = ! empty( $item->url )        ? $item->url        : '';
>-        $atts['role']   = ! empty( $item->role )       ? $item->role       : '';
>+        $atts['role']   = ! empty( $item->role )       ? $item->role       : 'menuitem';
> 
>         if ( in_array('menu-item-has-children', $item->classes) && 0 == $depth ) {
>             $atts['aria-haspopup'] = "true";
>diff --git a/Websites/webkit.org/wp-content/themes/webkit/widgets/post.php b/Websites/webkit.org/wp-content/themes/webkit/widgets/post.php
>index e3eb58b90d922ec561dab10ac1ae319d4d973196..98c0e4cae2aee253ee5f93da1fc0dbb09d59e428 100644
>--- a/Websites/webkit.org/wp-content/themes/webkit/widgets/post.php
>+++ b/Websites/webkit.org/wp-content/themes/webkit/widgets/post.php
>@@ -68,7 +68,7 @@ class WebKitPostTileWidget extends WP_Widget {
>                 <a class="tile-link" href="<?php the_permalink(); ?>"><?php echo $title; ?></a>
>                 <div class="background-image">
>                     <svg viewbox="0 0 100 100">
>-                        <use xlink:href="#<?php echo esc_attr(get_post_icon()); ?>" />
>+                        <use xlink:href="#<?php echo esc_attr(get_post_icon()); ?>" aria-label="<?php echo esc_attr(str_replace('-',' ', get_post_icon())); ?> icon" />
>                     </svg>
>                     <div class="featured-image"<?php echo $image; ?>></div>
>                     <?php if ( $featured ): ?><div class="background-vignette"></div><?php endif; ?>

Actions: View | Formatted Diff | Diff

Attachments on bug 198531: 371295 | 371310 | 371396