Attachment 371362 Details for Bug 198551 – Patch

[patch] Patch

bug-198551-20190604191438.patch (text/plain), 1.82 KB, created by Keith Rollin on 2019-06-04 19:14:39 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Keith Rollin

Created: 2019-06-04 19:14:39 PDT

Size: 1.82 KB

patch

obsolete

>Subversion Revision: 246050
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index b5a029e0d599ec2e8a6dee04ea2a691fa24e48cb..080d466003291d0e884aaa87631768e0a0974a76 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,19 @@
>+2019-06-04  Keith Rollin  <krollin@apple.com>
>+
>+        Remove TestWebKitAPI from some configurations
>+        https://bugs.webkit.org/show_bug.cgi?id=198551
>+        <rdar://problem/51424996>
>+
>+        TestWebKitAPI doesn't build on all configurations and is not used on
>+        all configurations. It doesn't build on tvOS simulator due to missing
>+        SSL functions. And it's not (yet) utilized on actual embedded devices.
>+        In light of all this, only build TestWebKitAPI on macOS, iOS
>+        simulator, and watchOS simulator.
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Makefile:
>+
> 2019-06-03  Sihui Liu  <sihui_liu@apple.com>
> 
>         [ Mac WK2 ] TestWebKitAPI.WKWebView.LocalStorageProcessCrashes is a flaky timeout when run locally.
>diff --git a/Tools/Makefile b/Tools/Makefile
>index 5d48e7724bfe7878db3b48902b82239d7fabda96..0a77dc5e35ebe4e6eca8070b4e3b38df05c2336f 100644
>--- a/Tools/Makefile
>+++ b/Tools/Makefile
>@@ -3,7 +3,12 @@ MODULES = DumpRenderTree WebKitTestRunner MiniBrowser ../Source/ThirdParty/gtest
> ifneq (,$(SDKROOT))
> 	ifeq (,$(findstring macosx,$(SDKROOT)))
> 		# Embedded OS
>-		MODULES = DumpRenderTree WebKitTestRunner ../Source/ThirdParty/gtest/xcode TestWebKitAPI
>+		MODULES = DumpRenderTree WebKitTestRunner ../Source/ThirdParty/gtest/xcode
>+		ifneq (,$(findstring simulator,$(SDKROOT)))		# Include TestWebKitAPI for simulators...
>+			ifeq (,$(findstring appletv,$(SDKROOT)))	# ...but not appletv simulator, due to missing SSL support
>+				MODULES += TestWebKitAPI
>+			endif
>+		endif
> 	endif
> 	ifneq (,$(findstring macosx,$(SDKROOT)))
> 		MODULES += lldb/lldbWebKitTester

Actions: View | Formatted Diff | Diff

Attachments on bug 198551: 371362 | 371419 | 371521