WebKit Bugzilla
Attachment 371357 Details for
Bug 198093
: [CMake] Build with hidden visibility by default
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
WIP Patch
hidden-visibility-potential-fix.diff (text/plain), 19.56 KB, created by
Christopher Reid
on 2019-06-04 17:34:56 PDT
(
hide
)
Description:
WIP Patch
Filename:
MIME Type:
Creator:
Christopher Reid
Created:
2019-06-04 17:34:56 PDT
Size:
19.56 KB
patch
obsolete
>diff --git a/Source/JavaScriptCore/API/glib/JSCContextPrivate.h b/Source/JavaScriptCore/API/glib/JSCContextPrivate.h >index fc7270ed52e..739fc4976c2 100644 >--- a/Source/JavaScriptCore/API/glib/JSCContextPrivate.h >+++ b/Source/JavaScriptCore/API/glib/JSCContextPrivate.h >@@ -25,15 +25,14 @@ > #include "JSContextRef.h" > #include <wtf/glib/GRefPtr.h> > >-GRefPtr<JSCContext> jscContextGetOrCreate(JSGlobalContextRef); >-JSGlobalContextRef jscContextGetJSContext(JSCContext*); >-GRefPtr<JSCValue> jscContextGetOrCreateValue(JSCContext*, JSValueRef); >-void jscContextValueDestroyed(JSCContext*, JSValueRef); >-JSC::JSObject* jscContextGetJSWrapper(JSCContext*, gpointer); >-JSC::JSObject* jscContextGetOrCreateJSWrapper(JSCContext*, JSClassRef, JSValueRef prototype = nullptr, gpointer = nullptr, GDestroyNotify = nullptr); >-JSGlobalContextRef jscContextCreateContextWithJSWrapper(JSCContext*, JSClassRef, JSValueRef prototype = nullptr, gpointer = nullptr, GDestroyNotify = nullptr); >-gpointer jscContextWrappedObject(JSCContext*, JSObjectRef); >-JSCClass* jscContextGetRegisteredClass(JSCContext*, JSClassRef); >+JS_EXPORT_PRIVATE GRefPtr<JSCContext> jscContextGetOrCreate(JSGlobalContextRef); >+JS_EXPORT_PRIVATE JSGlobalContextRef jscContextGetJSContext(JSCContext*); >+JS_EXPORT_PRIVATE GRefPtr<JSCValue> jscContextGetOrCreateValue(JSCContext*, JSValueRef); >+JS_EXPORT_PRIVATE void jscContextValueDestroyed(JSCContext*, JSValueRef); >+JS_EXPORT_PRIVATE JSC::JSObject* jscContextGetJSWrapper(JSCContext*, gpointer); JSC::JSObject* jscContextGetOrCreateJSWrapper(JSCContext*, JSClassRef, JSValueRef prototype = nullptr, gpointer = nullptr, GDestroyNotify = nullptr); >+JS_EXPORT_PRIVATE JSGlobalContextRef jscContextCreateContextWithJSWrapper(JSCContext*, JSClassRef, JSValueRef prototype = nullptr, gpointer = nullptr, GDestroyNotify = nullptr); >+JS_EXPORT_PRIVATE gpointer jscContextWrappedObject(JSCContext*, JSObjectRef); >+JS_EXPORT_PRIVATE JSCClass* jscContextGetRegisteredClass(JSCContext*, JSClassRef); > > struct CallbackData { > GRefPtr<JSCContext> context; >diff --git a/Source/JavaScriptCore/API/glib/JSCValuePrivate.h b/Source/JavaScriptCore/API/glib/JSCValuePrivate.h >index 62144353f55..9317d028af9 100644 >--- a/Source/JavaScriptCore/API/glib/JSCValuePrivate.h >+++ b/Source/JavaScriptCore/API/glib/JSCValuePrivate.h >@@ -21,5 +21,5 @@ > > #include "JSCValue.h" > >-JSValueRef jscValueGetJSValue(JSCValue*); >-JSCValue* jscValueCreate(JSCContext*, JSValueRef); >+JS_EXPORT_PRIVATE JSValueRef jscValueGetJSValue(JSCValue*); >+JS_EXPORT_PRIVATE JSCValue* jscValueCreate(JSCContext*, JSValueRef); >diff --git a/Source/JavaScriptCore/CMakeLists.txt b/Source/JavaScriptCore/CMakeLists.txt >index 9415ea07154..28efb38ea8b 100644 >--- a/Source/JavaScriptCore/CMakeLists.txt >+++ b/Source/JavaScriptCore/CMakeLists.txt >@@ -115,7 +115,14 @@ set(JavaScriptCore_OBJECT_LUT_SOURCES > ) > > set(JavaScriptCore_LIBRARIES >- WebKit::WTF >+ ICU::uc >+ ICU::data >+ ICU::i18n >+ -lpthread >+ ${GLIB_LIBRARIES} >+ ${CMAKE_DL_LIBS} >+ -Wl,--whole-archive WTF bmalloc >+ -Wl,--no-whole-archive > ) > > if (USE_CAPSTONE) >@@ -1303,6 +1310,12 @@ WEBKIT_COMPUTE_SOURCES(JavaScriptCore) > WEBKIT_WRAP_SOURCELIST(${JavaScriptCore_SOURCES}) > WEBKIT_FRAMEWORK(JavaScriptCore) > >+get_target_property(link_props JavaScriptCore INTERFACE_LINK_LIBRARIES) >+message("${link_props}") >+list(REMOVE_ITEM link_props WTF bmalloc -Wl,--whole-archive -Wl,--no-whole-archive) >+message("${link_props}") >+set_target_properties(JavaScriptCore PROPERTIES INTERFACE_LINK_LIBRARIES "${link_props}") >+ > if (NOT "${PORT}" STREQUAL "Mac") > if (${JavaScriptCore_LIBRARY_TYPE} STREQUAL "SHARED") > WEBKIT_POPULATE_LIBRARY_VERSION(JAVASCRIPTCORE) >diff --git a/Source/JavaScriptCore/inspector/remote/glib/RemoteInspectorServer.h b/Source/JavaScriptCore/inspector/remote/glib/RemoteInspectorServer.h >index f6c7b4efbde..e5bfc439fd4 100644 >--- a/Source/JavaScriptCore/inspector/remote/glib/RemoteInspectorServer.h >+++ b/Source/JavaScriptCore/inspector/remote/glib/RemoteInspectorServer.h >@@ -44,10 +44,10 @@ namespace Inspector { > > class RemoteInspectorServer { > public: >- static RemoteInspectorServer& singleton(); >- ~RemoteInspectorServer(); >+ JS_EXPORT_PRIVATE static RemoteInspectorServer& singleton(); >+ JS_EXPORT_PRIVATE ~RemoteInspectorServer(); > >- bool start(const char* address, unsigned port); >+ JS_EXPORT_PRIVATE bool start(const char* address, unsigned port); > bool isRunning() const { return !!m_dbusServer; } > > private: >diff --git a/Source/JavaScriptCore/inspector/remote/glib/RemoteInspectorUtils.h b/Source/JavaScriptCore/inspector/remote/glib/RemoteInspectorUtils.h >index 6f95ab5c52a..ea43307abdd 100644 >--- a/Source/JavaScriptCore/inspector/remote/glib/RemoteInspectorUtils.h >+++ b/Source/JavaScriptCore/inspector/remote/glib/RemoteInspectorUtils.h >@@ -35,7 +35,7 @@ typedef struct _GBytes GBytes; > namespace Inspector { > > GRefPtr<GBytes> backendCommands(); >-const CString& backendCommandsHash(); >+JS_EXPORT_PRIVATE const CString& backendCommandsHash(); > > } // namespace Inspector > >diff --git a/Source/WTF/wtf/DateMath.h b/Source/WTF/wtf/DateMath.h >index 8ba89e78dd2..5dadcfabfda 100644 >--- a/Source/WTF/wtf/DateMath.h >+++ b/Source/WTF/wtf/DateMath.h >@@ -92,7 +92,7 @@ WTF_EXPORT_PRIVATE double parseDateFromNullTerminatedCharacters(const char* date > WTF_EXPORT_PRIVATE double parseDateFromNullTerminatedCharacters(const char* dateString, bool& haveTZ, int& offset); > WTF_EXPORT_PRIVATE double timeClip(double); > // dayOfWeek: [0, 6] 0 being Monday, day: [1, 31], month: [0, 11], year: ex: 2011, hours: [0, 23], minutes: [0, 59], seconds: [0, 59], utcOffset: [-720,720]. >-String makeRFC2822DateString(unsigned dayOfWeek, unsigned day, unsigned month, unsigned year, unsigned hours, unsigned minutes, unsigned seconds, int utcOffset); >+WTF_EXPORT_PRIVATE String makeRFC2822DateString(unsigned dayOfWeek, unsigned day, unsigned month, unsigned year, unsigned hours, unsigned minutes, unsigned seconds, int utcOffset); > > inline double jsCurrentTime() > { >diff --git a/Source/WTF/wtf/FileSystem.h b/Source/WTF/wtf/FileSystem.h >index 32fe76df400..24b34a7172c 100644 >--- a/Source/WTF/wtf/FileSystem.h >+++ b/Source/WTF/wtf/FileSystem.h >@@ -128,7 +128,7 @@ bool excludeFromBackup(const String&); // Returns true if successful. > WTF_EXPORT_PRIVATE Vector<String> listDirectory(const String& path, const String& filter = String()); > > WTF_EXPORT_PRIVATE CString fileSystemRepresentation(const String&); >-String stringFromFileSystemRepresentation(const char*); >+WTF_EXPORT_PRIVATE String stringFromFileSystemRepresentation(const char*); > > inline bool isHandleValid(const PlatformFileHandle& handle) { return handle != invalidPlatformFileHandle; } > >@@ -171,7 +171,7 @@ WTF_EXPORT_PRIVATE RetainPtr<CFURLRef> pathAsURL(const String&); > #endif > > #if USE(GLIB) >-String filenameForDisplay(const String&); >+WTF_EXPORT_PRIVATE String filenameForDisplay(const String&); > #endif > > #if OS(WINDOWS) >diff --git a/Source/WTF/wtf/RunLoop.h b/Source/WTF/wtf/RunLoop.h >index d615e0740ec..b80d73c8353 100644 >--- a/Source/WTF/wtf/RunLoop.h >+++ b/Source/WTF/wtf/RunLoop.h >@@ -98,8 +98,8 @@ public: > virtual void fired() = 0; > > #if USE(GLIB_EVENT_LOOP) >- void setName(const char*); >- void setPriority(int); >+ WTF_EXPORT_PRIVATE void setName(const char*); >+ WTF_EXPORT_PRIVATE void setPriority(int); > #endif > > private: >diff --git a/Source/WTF/wtf/glib/GLibUtilities.h b/Source/WTF/wtf/glib/GLibUtilities.h >index 2993789c2ba..5b489b4e56d 100644 >--- a/Source/WTF/wtf/glib/GLibUtilities.h >+++ b/Source/WTF/wtf/glib/GLibUtilities.h >@@ -23,8 +23,8 @@ > #include <wtf/Assertions.h> > #include <wtf/text/CString.h> > >-CString getCurrentExecutablePath(); >-CString getCurrentExecutableName(); >+WTF_EXPORT CString getCurrentExecutablePath(); >+WTF_EXPORT CString getCurrentExecutableName(); > > // These might be added to glib in the future, but in the meantime they're defined here. > #ifndef GULONG_TO_POINTER >diff --git a/Source/WTF/wtf/linux/CurrentProcessMemoryStatus.h b/Source/WTF/wtf/linux/CurrentProcessMemoryStatus.h >index 27b5b3e202a..2ef133c80d1 100644 >--- a/Source/WTF/wtf/linux/CurrentProcessMemoryStatus.h >+++ b/Source/WTF/wtf/linux/CurrentProcessMemoryStatus.h >@@ -37,7 +37,7 @@ struct ProcessMemoryStatus { > size_t dt { 0 }; > }; > >-void currentProcessMemoryStatus(ProcessMemoryStatus&); >+WTF_EXPORT void currentProcessMemoryStatus(ProcessMemoryStatus&); > > } // namespace WTF > >diff --git a/Source/WebCore/platform/ContentType.h b/Source/WebCore/platform/ContentType.h >index c82b5b7197c..23e1f12bf2a 100644 >--- a/Source/WebCore/platform/ContentType.h >+++ b/Source/WebCore/platform/ContentType.h >@@ -37,11 +37,11 @@ public: > explicit ContentType(const String& type); > ContentType() = default; > >- static const String& codecsParameter(); >+ WEBCORE_EXPORT static const String& codecsParameter(); > static const String& profilesParameter(); > >- String parameter(const String& parameterName) const; >- String containerType() const; >+ WEBCORE_EXPORT String parameter(const String& parameterName) const; >+ WEBCORE_EXPORT String containerType() const; > Vector<String> codecs() const; > Vector<String> profiles() const; > const String& raw() const { return m_type; } >diff --git a/Source/WebCore/platform/graphics/MediaPlayer.h b/Source/WebCore/platform/graphics/MediaPlayer.h >index 3e1263bbb63..679fdd912d8 100644 >--- a/Source/WebCore/platform/graphics/MediaPlayer.h >+++ b/Source/WebCore/platform/graphics/MediaPlayer.h >@@ -402,15 +402,15 @@ public: > Preload preload() const; > void setPreload(Preload); > >- void networkStateChanged(); >- void readyStateChanged(); >+ WEBCORE_EXPORT void networkStateChanged(); >+ WEBCORE_EXPORT void readyStateChanged(); > void volumeChanged(double); > void muteChanged(bool); >- void timeChanged(); >+ WEBCORE_EXPORT void timeChanged(); > void sizeChanged(); > void rateChanged(); > void playbackStateChanged(); >- void durationChanged(); >+ WEBCORE_EXPORT void durationChanged(); > void firstVideoFrameAvailable(); > void characteristicChanged(); > >diff --git a/Source/WebCore/platform/graphics/PlatformTimeRanges.h b/Source/WebCore/platform/graphics/PlatformTimeRanges.h >index 1888695c76e..9a3ae8ad63c 100644 >--- a/Source/WebCore/platform/graphics/PlatformTimeRanges.h >+++ b/Source/WebCore/platform/graphics/PlatformTimeRanges.h >@@ -40,12 +40,12 @@ class PlatformTimeRanges { > WTF_MAKE_FAST_ALLOCATED; > public: > explicit PlatformTimeRanges() { } >- PlatformTimeRanges(const MediaTime& start, const MediaTime& end); >+ WEBCORE_EXPORT PlatformTimeRanges(const MediaTime& start, const MediaTime& end); > > WEBCORE_EXPORT MediaTime start(unsigned index) const; > MediaTime start(unsigned index, bool& valid) const; > WEBCORE_EXPORT MediaTime end(unsigned index) const; >- MediaTime end(unsigned index, bool& valid) const; >+ WEBCORE_EXPORT MediaTime end(unsigned index, bool& valid) const; > MediaTime duration(unsigned index) const; > MediaTime maximumBufferedTime() const; > >@@ -59,11 +59,11 @@ public: > > bool contain(const MediaTime&) const; > >- size_t find(const MediaTime&) const; >+ WEBCORE_EXPORT size_t find(const MediaTime&) const; > > MediaTime nearest(const MediaTime&) const; > >- MediaTime totalDuration() const; >+ WEBCORE_EXPORT MediaTime totalDuration() const; > > void dump(WTF::PrintStream&) const; > >diff --git a/Source/WebCore/platform/graphics/cairo/RefPtrCairo.h b/Source/WebCore/platform/graphics/cairo/RefPtrCairo.h >index aa1d19226b3..ec07678db24 100644 >--- a/Source/WebCore/platform/graphics/cairo/RefPtrCairo.h >+++ b/Source/WebCore/platform/graphics/cairo/RefPtrCairo.h >@@ -36,7 +36,7 @@ namespace WTF { > template<> void refIfNotNull(cairo_t* ptr); > template<> WEBCORE_EXPORT void derefIfNotNull(cairo_t* ptr); > >-template<> void refIfNotNull(cairo_surface_t* ptr); >+template<> WEBCORE_EXPORT void refIfNotNull(cairo_surface_t* ptr); > template<> WEBCORE_EXPORT void derefIfNotNull(cairo_surface_t* ptr); > > template<> void refIfNotNull(cairo_font_face_t* ptr); >diff --git a/Source/WebCore/platform/graphics/freetype/FontCacheFreeType.cpp b/Source/WebCore/platform/graphics/freetype/FontCacheFreeType.cpp >index db0485dbc33..018bc30609e 100644 >--- a/Source/WebCore/platform/graphics/freetype/FontCacheFreeType.cpp >+++ b/Source/WebCore/platform/graphics/freetype/FontCacheFreeType.cpp >@@ -34,6 +34,7 @@ > #include "UTF16UChar32Iterator.h" > #include <cairo-ft.h> > #include <cairo.h> >+#include <fontconfig/fontconfig.h> > #include <fontconfig/fcfreetype.h> > #include <wtf/Assertions.h> > #include <wtf/text/CString.h> >diff --git a/Source/WebCore/platform/network/soup/CertificateInfo.h b/Source/WebCore/platform/network/soup/CertificateInfo.h >index 939bae580a7..f147b7585a4 100644 >--- a/Source/WebCore/platform/network/soup/CertificateInfo.h >+++ b/Source/WebCore/platform/network/soup/CertificateInfo.h >@@ -40,7 +40,7 @@ namespace WebCore { > class ResourceError; > class ResourceResponse; > >-class CertificateInfo : public CertificateInfoBase { >+class WEBCORE_EXPORT CertificateInfo : public CertificateInfoBase { > public: > CertificateInfo(); > explicit CertificateInfo(const WebCore::ResourceResponse&); >diff --git a/Source/WebCore/platform/network/soup/SoupNetworkSession.h b/Source/WebCore/platform/network/soup/SoupNetworkSession.h >index ffbd49a762a..1dd413e5bb6 100644 >--- a/Source/WebCore/platform/network/soup/SoupNetworkSession.h >+++ b/Source/WebCore/platform/network/soup/SoupNetworkSession.h >@@ -65,7 +65,7 @@ public: > static void setInitialAcceptLanguages(const CString&); > void setAcceptLanguages(const CString&); > >- static void setShouldIgnoreTLSErrors(bool); >+ WEBCORE_EXPORT static void setShouldIgnoreTLSErrors(bool); > static Optional<ResourceError> checkTLSErrors(const URL&, GTlsCertificate*, GTlsCertificateFlags); > static void allowSpecificHTTPSCertificateForHost(const CertificateInfo&, const String& host); > >diff --git a/Source/WebDriver/CMakeLists.txt b/Source/WebDriver/CMakeLists.txt >index eeaa4f09d0a..2c93fa055b0 100644 >--- a/Source/WebDriver/CMakeLists.txt >+++ b/Source/WebDriver/CMakeLists.txt >@@ -18,7 +18,8 @@ set(WebDriver_SOURCES > ) > > set(WebDriver_LIBRARIES >- WebKit::WTF >+ WTF >+ bmalloc > ) > > set(WebDriver_SCRIPTS >diff --git a/Source/WebKit/PlatformGTK.cmake b/Source/WebKit/PlatformGTK.cmake >index b18db404895..807e10178dd 100644 >--- a/Source/WebKit/PlatformGTK.cmake >+++ b/Source/WebKit/PlatformGTK.cmake >@@ -417,6 +417,7 @@ list(APPEND WebKit_INCLUDE_DIRECTORIES > "${WEBKIT_DIR}/WebProcess/WebPage/CoordinatedGraphics" > "${WEBKIT_DIR}/WebProcess/WebPage/atk" > "${WEBKIT_DIR}/WebProcess/WebPage/gtk" >+ "${CMAKE_BINARY_DIR}" # for cmakeconfig > ) > > list(APPEND WebKit_SYSTEM_INCLUDE_DIRECTORIES >diff --git a/Source/WebKit/UIProcess/gtk/InputMethodFilter.h b/Source/WebKit/UIProcess/gtk/InputMethodFilter.h >index 2a4af6ac03c..d004627719b 100644 >--- a/Source/WebKit/UIProcess/gtk/InputMethodFilter.h >+++ b/Source/WebKit/UIProcess/gtk/InputMethodFilter.h >@@ -20,6 +20,7 @@ > #ifndef InputMethodFilter_h > #define InputMethodFilter_h > >+#include "WKDeclarationSpecifiers.h" > #include <WebCore/IntPoint.h> > #include <wtf/Function.h> > #include <wtf/Noncopyable.h> >@@ -46,21 +47,21 @@ public: > EventNotFaked > }; > >- InputMethodFilter(); >- ~InputMethodFilter(); >+ WK_EXPORT InputMethodFilter(); >+ WK_EXPORT ~InputMethodFilter(); > > GtkIMContext* context() const { return m_context.get(); } > > void setPage(WebPageProxy* page) { m_page = page; } > >- void setEnabled(bool); >+ WK_EXPORT void setEnabled(bool); > void setCursorRect(const WebCore::IntRect&); > > using FilterKeyEventCompletionHandler = Function<void(const WebCore::CompositionResults&, InputMethodFilter::EventFakedForComposition)>; >- void filterKeyEvent(GdkEventKey*, FilterKeyEventCompletionHandler&& = nullptr); >- void notifyFocusedIn(); >- void notifyFocusedOut(); >- void notifyMouseButtonPress(); >+ WK_EXPORT void filterKeyEvent(GdkEventKey*, FilterKeyEventCompletionHandler&& = nullptr); >+ WK_EXPORT void notifyFocusedIn(); >+ WK_EXPORT void notifyFocusedOut(); >+ WK_EXPORT void notifyMouseButtonPress(); > > #if ENABLE(API_TESTS) > void setTestingMode(bool enable) { m_testingMode = enable; } >diff --git a/Source/bmalloc/bmalloc/BPlatform.h b/Source/bmalloc/bmalloc/BPlatform.h >index f7a4af43d3e..d3e1ada5c92 100644 >--- a/Source/bmalloc/bmalloc/BPlatform.h >+++ b/Source/bmalloc/bmalloc/BPlatform.h >@@ -236,7 +236,8 @@ > #define BUSE_OS_LOG 1 > #endif > >-#if !defined(BUSE_EXPORT_MACROS) && (BPLATFORM(MAC) || BPLATFORM(IOS_FAMILY)) >+// TODO BUSE_EXPORT_MACROS cmake settings should carry over to here >+#if !defined(BUSE_EXPORT_MACROS) && (BPLATFORM(MAC) || BPLATFORM(IOS_FAMILY) || 1) > #define BUSE_EXPORT_MACROS 1 > #endif > >diff --git a/Source/cmake/OptionsGTK.cmake b/Source/cmake/OptionsGTK.cmake >index b3935a870ac..c13f2cdf1a6 100644 >--- a/Source/cmake/OptionsGTK.cmake >+++ b/Source/cmake/OptionsGTK.cmake >@@ -110,7 +110,7 @@ WEBKIT_OPTION_DEPEND(USE_WPE_RENDERER ENABLE_WAYLAND_TARGET) > SET_AND_EXPOSE_TO_BUILD(ENABLE_DEVELOPER_MODE ${DEVELOPER_MODE}) > if (DEVELOPER_MODE) > WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MINIBROWSER PUBLIC ON) >- WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_API_TESTS PRIVATE ON) >+ WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_API_TESTS PRIVATE OFF) # TODO turn back on > else () > WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MINIBROWSER PUBLIC OFF) > WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_API_TESTS PRIVATE OFF) >@@ -200,6 +200,8 @@ set(GDK_INCLUDE_DIRS ${GDK3_INCLUDE_DIRS}) > SET_AND_EXPOSE_TO_BUILD(HAVE_GTK_GESTURES ${GTK3_SUPPORTS_GESTURES}) > SET_AND_EXPOSE_TO_BUILD(HAVE_GTK_UNIX_PRINTING ${GTKUnixPrint_FOUND}) > SET_AND_EXPOSE_TO_BUILD(HAVE_OS_DARK_MODE_SUPPORT 1) >+SET_AND_EXPOSE_TO_BUILD(USE_EXPORT_MACROS ON) >+SET_AND_EXPOSE_TO_BUILD(BUSE_EXPORT_MACROS ON) > > set(glib_components gio gio-unix gobject gthread gmodule) > find_package(GLIB 2.36 REQUIRED COMPONENTS ${glib_components}) >diff --git a/Source/cmake/WebKitCompilerFlags.cmake b/Source/cmake/WebKitCompilerFlags.cmake >index 1f802d42a61..e6f820f653b 100644 >--- a/Source/cmake/WebKitCompilerFlags.cmake >+++ b/Source/cmake/WebKitCompilerFlags.cmake >@@ -103,6 +103,7 @@ if (COMPILER_IS_GCC_OR_CLANG) > else () > WEBKIT_APPEND_GLOBAL_COMPILER_FLAGS(-fno-exceptions) > WEBKIT_APPEND_GLOBAL_CXX_FLAGS(-fno-rtti) >+ WEBKIT_APPEND_GLOBAL_COMPILER_FLAGS(-fvisibility=hidden) > > check_cxx_compiler_flag("-std=c++17" CXX_COMPILER_SUPPORTS_CXX17) > if (CXX_COMPILER_SUPPORTS_CXX17) >diff --git a/Tools/TestWebKitAPI/CMakeLists.txt b/Tools/TestWebKitAPI/CMakeLists.txt >index bdaca4972d4..7bfc1db5eb0 100644 >--- a/Tools/TestWebKitAPI/CMakeLists.txt >+++ b/Tools/TestWebKitAPI/CMakeLists.txt >@@ -105,7 +105,8 @@ set(TestWTF_PRIVATE_INCLUDE_DIRECTORIES > ) > > set(TestWTF_LIBRARIES >- WebKit::WTF >+ WTF >+ bmalloc > gtest > ) > >diff --git a/Tools/TestWebKitAPI/InjectedBundleMain.cpp b/Tools/TestWebKitAPI/InjectedBundleMain.cpp >index b2537f737d5..b78b6c9c693 100644 >--- a/Tools/TestWebKitAPI/InjectedBundleMain.cpp >+++ b/Tools/TestWebKitAPI/InjectedBundleMain.cpp >@@ -32,6 +32,8 @@ > > #if defined(WIN32) || defined(_WIN32) > extern "C" __declspec(dllexport) >+#elif defined(unix) || defined(__unix) >+extern "C" __attribute__((visibility("default"))) > #else > extern "C" > #endif >diff --git a/Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp b/Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp >index dfa3d318f57..e3ff24bf9f9 100644 >--- a/Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp >+++ b/Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp >@@ -30,6 +30,8 @@ > > #if defined(WIN32) > extern "C" __declspec(dllexport) >+#elif defined(unix) || defined(__unix) >+extern "C" __attribute__((visibility("default"))) > #else > extern "C" > #endif
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 198093
:
370355
|
370782
| 371357