Attachment 371349 Details for Bug 198547 – Patch

[patch] Patch

bug-198547-20190604162553.patch (text/plain), 3.27 KB, created by Tim Horton on 2019-06-04 16:25:54 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Tim Horton

Created: 2019-06-04 16:25:54 PDT

Size: 3.27 KB

patch

obsolete

>Subversion Revision: 246044
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 3638a0682ed018fabaabb5c75b40302d57e2d0e6..92f3e80c8d5fc1c3b323d68e3f24dd83e21f3e13 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-06-04  Tim Horton  <timothy_horton@apple.com>
>+
>+        Turn on background color estimation for all link indicators
>+        https://bugs.webkit.org/show_bug.cgi?id=198547
>+        <rdar://problem/51140196>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * WebProcess/WebPage/ios/WebPageIOS.mm:
>+        (WebKit::WebPage::computeAndSendEditDragSnapshot):
>+        (WebKit::linkIndicatorPositionInformation):
>+
> 2019-06-03  Darin Adler  <darin@apple.com>
> 
>         Finish cleanup of String::number for floating point
>diff --git a/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm b/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
>index c9ce18f1f2519cf8d8008bf6b95ee8c2f2c225e8..2b5941a1279d78a428f835d0648fef9f4cbd31e4 100644
>--- a/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
>+++ b/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
>@@ -879,7 +879,7 @@ void WebPage::didFinishLoadingImageForElement(WebCore::HTMLImageElement& element
> void WebPage::computeAndSendEditDragSnapshot()
> {
>     Optional<TextIndicatorData> textIndicatorData;
>-    static auto defaultTextIndicatorOptionsForEditDrag = TextIndicatorOptionIncludeSnapshotOfAllVisibleContentWithoutSelection | TextIndicatorOptionExpandClipBeyondVisibleRect | TextIndicatorOptionPaintAllContent | TextIndicatorOptionIncludeMarginIfRangeMatchesSelection | TextIndicatorOptionPaintBackgrounds | TextIndicatorOptionComputeEstimatedBackgroundColor| TextIndicatorOptionUseSelectionRectForSizing | TextIndicatorOptionIncludeSnapshotWithSelectionHighlight;
>+    static auto defaultTextIndicatorOptionsForEditDrag = TextIndicatorOptionIncludeSnapshotOfAllVisibleContentWithoutSelection | TextIndicatorOptionExpandClipBeyondVisibleRect | TextIndicatorOptionPaintAllContent | TextIndicatorOptionIncludeMarginIfRangeMatchesSelection | TextIndicatorOptionPaintBackgrounds | TextIndicatorOptionComputeEstimatedBackgroundColor | TextIndicatorOptionUseSelectionRectForSizing | TextIndicatorOptionIncludeSnapshotWithSelectionHighlight;
>     if (auto range = std::exchange(m_rangeForDropSnapshot, nullptr)) {
>         if (auto textIndicator = TextIndicator::createWithRange(*range, defaultTextIndicatorOptionsForEditDrag, TextIndicatorPresentationTransition::None, { }))
>             textIndicatorData = textIndicator->data();
>@@ -2533,7 +2533,7 @@ static void linkIndicatorPositionInformation(WebPage& page, Element& element, El
> 
>     auto textIndicator = TextIndicator::createWithRange(linkRange.get(),
>         TextIndicatorOptionTightlyFitContent | TextIndicatorOptionRespectTextColor | TextIndicatorOptionPaintBackgrounds |
>-        TextIndicatorOptionUseBoundingRectAndPaintAllContentForComplexRanges | TextIndicatorOptionIncludeMarginIfRangeMatchesSelection,
>+        TextIndicatorOptionUseBoundingRectAndPaintAllContentForComplexRanges | TextIndicatorOptionIncludeMarginIfRangeMatchesSelection | TextIndicatorOptionComputeEstimatedBackgroundColor,
>         TextIndicatorPresentationTransition::None, FloatSize(marginInPoints * deviceScaleFactor, marginInPoints * deviceScaleFactor));
>         
>     if (textIndicator)

Actions: View | Formatted Diff | Diff

Attachments on bug 198547: 371349