Attachment 371329 Details for Bug 198218 – Patch

[patch] Patch

bug-198218-20190604171220.patch (text/plain), 2.01 KB, created by Aakash Jain on 2019-06-04 14:12:21 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Aakash Jain

Created: 2019-06-04 14:12:21 PDT

Size: 2.01 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 246076)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,13 @@
>+2019-06-04  Aakash Jain  <aakash_jain@apple.com>
>+
>+        [ews-build] Do not display unnecessary steps in the Buildbot build page UI
>+        https://bugs.webkit.org/show_bug.cgi?id=198218
>+        <rdar://problem/51104544>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * BuildSlaveSupport/ews-build/steps.py:
>+
> 2019-06-04  Takashi Komori  <Takashi.Komori@sony.com>
> 
>         [WinCairo] Implement cpu and memory measuring functions.
>Index: Tools/BuildSlaveSupport/ews-build/steps.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-build/steps.py	(revision 246077)
>+++ Tools/BuildSlaveSupport/ews-build/steps.py	(working copy)
>@@ -139,6 +139,9 @@ class ApplyPatch(shell.ShellCommand, Com
>         d = self.downloadFileContentToWorker('.buildbot-diff', patch)
>         d.addCallback(lambda res: shell.ShellCommand.start(self))
> 
>+    def hideStepIf(self, results, step):
>+        return results == SUCCESS and self.getProperty('validated', '') == False
>+
>     def getResultSummary(self):
>         if self.results != SUCCESS:
>             return {u'step': u'Patch does not apply'}
>@@ -368,6 +371,7 @@ class ValidatePatch(buildstep.BuildStep)
> 
>         if obsolete == -1 or review_denied == -1 or bug_closed == -1:
>             self.finished(WARNINGS)
>+            self.setProperty('validated', False)
>             return None
> 
>         self._addToLog('stdio', 'Bug is open.\nPatch is not obsolete.\nPatch is not marked r-.\n')
>@@ -809,6 +813,9 @@ class TransferToS3(master.MasterShellCom
> 
>         return super(TransferToS3, self).finished(results)
> 
>+    def hideStepIf(self, results, step):
>+        return results == SUCCESS and self.getProperty('validated', '') == False
>+
>     def getResultSummary(self):
>         if self.results != SUCCESS:
>             return {u'step': u'Failed to transfer archive to S3'}

Flags:

jbedard: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 198218: 370570 | 370574 | 371315 | 371329