Attachment 371323 Details for Bug 198540 – Patch

[patch] Patch

bug-198540-20190604131136.patch (text/plain), 1.82 KB, created by Keith Rollin on 2019-06-04 13:11:36 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Keith Rollin

Created: 2019-06-04 13:11:36 PDT

Size: 1.82 KB

patch

obsolete

>Subversion Revision: 246050
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index dc1c53903886811abd1dd1d96bce78587aa33d6f..9e7e7e10cbf200a9d89a86a85abbb6daf104fdbf 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,22 @@
>+2019-06-04  Keith Rollin  <krollin@apple.com>
>+
>+        Fix 64-bit vs 32-bit mismatch in TileController.cpp
>+        https://bugs.webkit.org/show_bug.cgi?id=198540
>+        <rdar://problem/51410851>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        TileController::blankPixelCountForTiles calculates its result as a
>+        uint64_t, but returns it as an unsigned. The former is a 64-bit value,
>+        while the latter can be a 32-bit value on some platforms. This
>+        mismatch can lead to a compile-time error. Fix this by explicitly
>+        casting the 64-bit value to a "signed".
>+
>+        No new tests -- no new functionality.
>+
>+        * platform/graphics/ca/TileController.cpp:
>+        (WebCore::TileController::blankPixelCountForTiles):
>+
> 2019-06-04  Keith Rollin  <krollin@apple.com>
> 
>         Fix 64-bit vs 32-bit mismatch in ISOFairPlayStreamingPsshBox.cpp
>diff --git a/Source/WebCore/platform/graphics/ca/TileController.cpp b/Source/WebCore/platform/graphics/ca/TileController.cpp
>index 75fe759a8eed32ac3ace87fbf860e12224071855..262de8b4248d845538bae39a34907f6f2638dbb8 100644
>--- a/Source/WebCore/platform/graphics/ca/TileController.cpp
>+++ b/Source/WebCore/platform/graphics/ca/TileController.cpp
>@@ -650,7 +650,7 @@ unsigned TileController::blankPixelCountForTiles(const PlatformLayerList& tiles,
>     Region uncoveredRegion(enclosingIntRect(visibleRect));
>     uncoveredRegion.subtract(paintedVisibleTiles);
> 
>-    return uncoveredRegion.totalArea();
>+    return static_cast<unsigned>(uncoveredRegion.totalArea());
> }
> 
> void TileController::setNeedsRevalidateTiles()

Actions: View | Formatted Diff | Diff

Attachments on bug 198540: 371323 | 371352 | 371353