Attachment 371254 Details for Bug 185001 – Needs a test

[patch] Needs a test

bug-185001-20190604010507.patch (text/plain), 1.38 KB, created by Andy Estes on 2019-06-04 01:05:07 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Andy Estes

Created: 2019-06-04 01:05:07 PDT

Size: 1.38 KB

patch

obsolete

>Subversion Revision: 246043
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 3638a0682ed018fabaabb5c75b40302d57e2d0e6..fb29bc63f470933eb8b4b4d3a57cda110209122b 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,14 @@
>+2019-06-04  Andy Estes  <aestes@apple.com>
>+
>+        Click events on outer page are not being dispatched correctly after touch-zooming within an iframe
>+        https://bugs.webkit.org/show_bug.cgi?id=185001
>+        <rdar://problem/40569615>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * WebProcess/WebPage/WebPage.cpp:
>+        (WebKit::WebPage::updatePotentialTapSecurityOrigin):
>+
> 2019-06-03  Darin Adler  <darin@apple.com>
> 
>         Finish cleanup of String::number for floating point
>diff --git a/Source/WebKit/WebProcess/WebPage/WebPage.cpp b/Source/WebKit/WebProcess/WebPage/WebPage.cpp
>index 6d3d7c53a4c581964347898c49c7b1e971648c25..c468ad0a9165bc38cf9016121a2b02015a183020 100644
>--- a/Source/WebKit/WebProcess/WebPage/WebPage.cpp
>+++ b/Source/WebKit/WebProcess/WebPage/WebPage.cpp
>@@ -2907,6 +2907,9 @@ void WebPage::touchEventSync(const WebTouchEvent& touchEvent, CompletionHandler<
> 
> void WebPage::updatePotentialTapSecurityOrigin(const WebTouchEvent& touchEvent, bool wasHandled)
> {
>+    if (touchEvent.type() == WebEvent::TouchStart)
>+        m_potentialTapSecurityOrigin = nullptr;
>+
>     if (wasHandled)
>         return;
>

Actions: View | Formatted Diff | Diff

Attachments on bug 185001: 338799 | 343530 | 343531 | 371254 | 373454 | 373455