Attachment 371244 Details for Bug 198434 – Patch for landing

[patch] Patch for landing

bug-198434-20190603214555.patch (text/plain), 1.79 KB, created by youenn fablet on 2019-06-03 21:45:56 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2019-06-03 21:45:56 PDT

Size: 1.79 KB

patch

obsolete

>Subversion Revision: 246034
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 894f37d9d30b45c4eda37caf60ae7bdcca5960c2..205a9c990ac7a14c592a403aba49843b848d4ec1 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-06-03  Youenn Fablet  <youenn@apple.com>
>+
>+        REGRESSION (r245913) [ Debug ] ASSERTION FAILED: m_swConnectionsByIdentifier.contains(connection.serverConnectionIdentifier()) Layout Test http/wpt/service-workers/update-service-worker.https.html is a flaky crash
>+        https://bugs.webkit.org/show_bug.cgi?id=198434
>+        <rdar://problem/51313917>
>+
>+        Reviewed by Alex Christensen.
>+
>+        Iterate through the connectionID-based connection map instead of the sessionID-based map to notify them their connection is lost.
>+
>+        * WebProcess/Network/NetworkProcessConnection.cpp:
>+        (WebKit::NetworkProcessConnection::didClose):
>+
> 2019-06-03  Youenn Fablet  <youenn@apple.com>
> 
>         getUserMedia requests should be processed sequentially in UIProcess
>diff --git a/Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp b/Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp
>index 161f8da41fa86e611fd943107dfe6f63640c3e2e..3c6de399b525c7f6da22183a27be6bdd725f335f 100644
>--- a/Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp
>+++ b/Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp
>@@ -195,8 +195,8 @@ void NetworkProcessConnection::didClose(IPC::Connection&)
> #endif
> 
> #if ENABLE(SERVICE_WORKER)
>-    m_swConnectionsByIdentifier.clear();
>-    for (auto& connection : m_swConnectionsBySession.values())
>+    auto connections = std::exchange(m_swConnectionsByIdentifier, { });
>+    for (auto& connection : connections.values())
>         connection->connectionToServerLost();
> #endif
> }

Actions: View | Formatted Diff | Diff

Attachments on bug 198434: 371094 | 371244