Attachment 371180 Details for Bug 198478 – Patch

[patch] Patch

bug-198478-20190603172346.patch (text/plain), 1.79 KB, created by Fujii Hironori on 2019-06-03 01:23:47 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Fujii Hironori

Created: 2019-06-03 01:23:47 PDT

Size: 1.79 KB

patch

obsolete

>Subversion Revision: 246028
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 0ae2a31e86e4d05aafbe15edb3e6a522e0ed3b6c..947e928442ac65f987ea1ec5ff3ee0ddcc98de25 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,19 @@
>+2019-06-03  Fujii Hironori  <Hironori.Fujii@sony.com>
>+
>+        REGRESSION(r240862) [WinCairo][WK2] position:fixed elements don't show
>+        https://bugs.webkit.org/show_bug.cgi?id=198478
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        All position:fixed elements didn't show in WinCairo WebKit2 since
>+        r240862 which turns acceleratedCompositingEnabled on for WebKit2.
>+        WinCairo WebKit2 doesn't have accelerated compositing support yet.
>+        Let's do the same with GTK port.
>+
>+        * WebProcess/WebPage/WebPage.cpp:
>+        (WebKit::WebPage::updatePreferences): Conditioned out the code
>+        enabling acceleratedCompositingEnabled for PLATFORM(WIN).
>+
> 2019-06-01  Dean Jackson  <dino@apple.com>
> 
>         Provide an action to save an image on a link sheet
>diff --git a/Source/WebKit/WebProcess/WebPage/WebPage.cpp b/Source/WebKit/WebProcess/WebPage/WebPage.cpp
>index 436ff63468ecc9fc18502b32499c692c82d780a4..6d3d7c53a4c581964347898c49c7b1e971648c25 100644
>--- a/Source/WebKit/WebProcess/WebPage/WebPage.cpp
>+++ b/Source/WebKit/WebProcess/WebPage/WebPage.cpp
>@@ -3519,7 +3519,7 @@ void WebPage::updatePreferences(const WebPreferencesStore& store)
> 
>     Settings& settings = m_page->settings();
> 
>-#if !PLATFORM(GTK)
>+#if !PLATFORM(GTK) && !PLATFORM(WIN)
>     if (!settings.acceleratedCompositingEnabled()) {
>         RELEASE_LOG_IF_ALLOWED("%p - WebPage - acceleratedCompositingEnabled setting was false. WebKit cannot function in this mode; changing setting to true", this);
>         settings.setAcceleratedCompositingEnabled(true);

Flags:

cgarcia: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 198478: 371180