Attachment 371177 Details for Bug 198476 – Patch

[patch] Patch

bug-198476-20190603083259.patch (text/plain), 4.47 KB, created by Zan Dobersek on 2019-06-02 23:33:00 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Zan Dobersek

Created: 2019-06-02 23:33:00 PDT

Size: 4.47 KB

patch

obsolete

>Subversion Revision: 246028
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 196d2609c9e3d7207ffa92d1da2ea763f36a2105..3084b675c2984effa10aba1708e476eb17acef4b 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,14 @@
>+2019-06-02  Zan Dobersek  <zdobersek@igalia.com>
>+
>+        [Nicosia] Disable async scrolling until implemented
>+        https://bugs.webkit.org/show_bug.cgi?id=198476
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * page/scrolling/ScrollingCoordinator.cpp:
>+        Build the ScrollingCoordinator::create() method whenever ASYNC_SCROLLING
>+        is not enabled.
>+
> 2019-06-01  Simon Fraser  <simon.fraser@apple.com>
> 
>         [Async overflow scroll] Flashing content when scrolling async overflow with a negative z-index child
>diff --git a/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp b/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp
>index 4b03db85956e4d5e9b7913462b7b0367d6948bed..62e4f22dbcd4fc297acd0307879376cc552de50b 100644
>--- a/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp
>+++ b/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp
>@@ -47,7 +47,7 @@
> 
> namespace WebCore {
> 
>-#if !PLATFORM(MAC) && !USE(COORDINATED_GRAPHICS)
>+#if !ENABLE(ASYNC_SCROLLING)
> Ref<ScrollingCoordinator> ScrollingCoordinator::create(Page* page)
> {
>     return adoptRef(*new ScrollingCoordinator(page));
>diff --git a/Source/cmake/OptionsGTK.cmake b/Source/cmake/OptionsGTK.cmake
>index b3935a870ace68c83414c2f09980b3f55e0f5571..633ff282f46a7de3336dd7487f442dbd338cd8ff 100644
>--- a/Source/cmake/OptionsGTK.cmake
>+++ b/Source/cmake/OptionsGTK.cmake
>@@ -142,7 +142,7 @@ endif ()
> # without approval from a GTK+ reviewer. There must be strong reason to support
> # changing the value of the option.
> WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ACCELERATED_2D_CANVAS PUBLIC OFF)
>-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ASYNC_SCROLLING PRIVATE ON)
>+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ASYNC_SCROLLING PRIVATE OFF)
> WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DRAG_SUPPORT PUBLIC ON)
> WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ICONDATABASE PUBLIC ON)
> WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SPELLCHECK PUBLIC ON)
>diff --git a/Source/cmake/OptionsPlayStation.cmake b/Source/cmake/OptionsPlayStation.cmake
>index 4028b772b5f90e4f50dc9a70cfc8da5fda3eaa82..32128f1cc29ae1b847ec0daca2dfa660c5719bc2 100644
>--- a/Source/cmake/OptionsPlayStation.cmake
>+++ b/Source/cmake/OptionsPlayStation.cmake
>@@ -12,7 +12,7 @@ WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_FTL_JIT PRIVATE OFF)
> WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DFG_JIT PRIVATE OFF)
> 
> # Enabled features
>-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ASYNC_SCROLLING PRIVATE ON)
>+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ASYNC_SCROLLING PRIVATE OFF)
> WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SMOOTH_SCROLLING PRIVATE ON)
> 
> # Experimental features
>diff --git a/Source/cmake/OptionsWPE.cmake b/Source/cmake/OptionsWPE.cmake
>index 1d403af8659271682d3c6ff5e09d5b7dc1c64733..5c99232ba0cd49d35dfdeb1e8bc61c4048f27abb 100644
>--- a/Source/cmake/OptionsWPE.cmake
>+++ b/Source/cmake/OptionsWPE.cmake
>@@ -46,7 +46,7 @@ WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_XSLT PUBLIC ON)
> # Private options shared with other WebKit ports. Add options here only if
> # we need a value different from the default defined in WebKitFeatures.cmake.
> # Changing these options is completely unsupported.
>-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ASYNC_SCROLLING PRIVATE ON)
>+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ASYNC_SCROLLING PRIVATE OFF)
> WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CONTENT_EXTENSIONS PRIVATE ON)
> WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MEDIA_STREAM PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
> WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MHTML PRIVATE ON)
>diff --git a/ChangeLog b/ChangeLog
>index 4fb464521d95111461e7b3a7d1b131a226c7a165..1e95c3ba2404d49a262231e446bda96b9ef6d244 100644
>--- a/ChangeLog
>+++ b/ChangeLog
>@@ -1,3 +1,18 @@
>+2019-06-02  Zan Dobersek  <zdobersek@igalia.com>
>+
>+        [Nicosia] Disable async scrolling until implemented
>+        https://bugs.webkit.org/show_bug.cgi?id=198476
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Disable async scrolling on Nicosia-using ports until the underlying
>+        implementation is complete, allowing easier refactorings of the general
>+        async scrolling system.
>+
>+        * Source/cmake/OptionsGTK.cmake:
>+        * Source/cmake/OptionsPlayStation.cmake:
>+        * Source/cmake/OptionsWPE.cmake:
>+
> 2019-05-30  Don Olmstead  <don.olmstead@sony.com>
> 
>         [CMake] Add WEBKIT_FRAMEWORK_TARGET macro

Actions: View | Formatted Diff | Diff

Attachments on bug 198476: 371177 | 371178 | 371179 | 371182