Attachment 371175 Details for Bug 198474 – Patch

[patch] Patch

bug-198474-20190603141220.patch (text/plain), 1.54 KB, created by Fujii Hironori on 2019-06-02 22:12:21 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Fujii Hironori

Created: 2019-06-02 22:12:21 PDT

Size: 1.54 KB

patch

obsolete

>Subversion Revision: 246027
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 288349033ceec728bdcd2b28d92272549e0c674c..dd97d05b450ac499c1b6a616a5a34dd7eafb178b 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,19 @@
>+2019-06-02  Fujii Hironori  <Hironori.Fujii@sony.com>
>+
>+        [WinCairo][MiniBrowser] WKViewSetIsInWindow should be called
>+        https://bugs.webkit.org/show_bug.cgi?id=198474
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        WinCairo WK2 MiniBrowser can't play back videos because
>+        Page::canStartMedia() always returns false. WKViewSetIsInWindow
>+        should be called.
>+
>+        The original MiniBrowser did it in Bug 55364.
>+
>+        * MiniBrowser/win/WebKitBrowserWindow.cpp:
>+        (WebKitBrowserWindow::WebKitBrowserWindow): Call WKViewSetIsInWindow.
>+
> 2019-05-31  Sihui Liu  <sihui_liu@apple.com>
> 
>         TestWebKitAPI.WKWebView.LocalStorageProcessSuspends is flaky
>diff --git a/Tools/MiniBrowser/win/WebKitBrowserWindow.cpp b/Tools/MiniBrowser/win/WebKitBrowserWindow.cpp
>index 353c2b1e5acf331a24682eb6db3f8705899f744b..32916143f43852434d1b87f93a818026352fd9f6 100644
>--- a/Tools/MiniBrowser/win/WebKitBrowserWindow.cpp
>+++ b/Tools/MiniBrowser/win/WebKitBrowserWindow.cpp
>@@ -129,6 +129,8 @@ WebKitBrowserWindow::WebKitBrowserWindow(WKPageConfigurationRef conf, HWND mainW
> {
>     RECT rect = { };
>     m_view = adoptWK(WKViewCreate(rect, conf, mainWnd));
>+    WKViewSetIsInWindow(m_view.get(), true);
>+
>     auto page = WKViewGetPage(m_view.get());
> 
>     WKPageNavigationClientV0 navigationClient = { };

Actions: View | Formatted Diff | Diff

Attachments on bug 198474: 371175