Attachment 371127 Details for Bug 169356 – Patch

[patch] Patch

bug-169356-20190601160708.patch (text/plain), 2.56 KB, created by Patrick Griffis on 2019-06-01 16:07:09 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Patrick Griffis

Created: 2019-06-01 16:07:09 PDT

Size: 2.56 KB

patch

obsolete

>Subversion Revision: 246015
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 3c90c41e1c61c3f857652ed35d1320ff6e9d0071..79486665bdabd94417d52a92e7ef55a991388440 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,18 @@
>+2019-06-01  Patrick Griffis  <pgriffis@igalia.com>
>+
>+        [SOUP] Use new API for strict secure cookies
>+        https://bugs.webkit.org/show_bug.cgi?id=169356
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        The new soup API implements this new spec:
>+
>+        https://tools.ietf.org/html/draft-ietf-httpbis-cookie-alone-01
>+
>+        * platform/network/soup/NetworkStorageSessionSoup.cpp:
>+        (WebCore::NetworkStorageSession::setCookiesFromDOM const):
>+        (WebCore::NetworkStorageSession::setCookies):
>+
> 2019-06-01  Andy Estes  <aestes@apple.com>
> 
>         [Apple Pay] Every PaymentCoordinator client should explicitly decide whether they support unrestricted Apple Pay
>diff --git a/Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp b/Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp
>index f6641efeb44c73434e4d15a4a5abedd856f20e6f..15a3981649bda5e6affd43da718a4846b73e4cef 100644
>--- a/Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp
>+++ b/Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp
>@@ -321,16 +321,28 @@ void NetworkStorageSession::setCookiesFromDOM(const URL& firstParty, const SameS
>         if (httpOnlyCookieExists(existingCookies, soup_cookie_get_name(cookie.get()), soup_cookie_get_path(cookie.get())))
>             continue;
> 
>+#if SOUP_CHECK_VERSION(2, 67, 1)
>+        soup_cookie_jar_add_cookie_full(jar, cookie.release(), origin.get(), firstPartyURI.get());
>+#else
>         soup_cookie_jar_add_cookie_with_first_party(jar, firstPartyURI.get(), cookie.release());
>+#endif
>     }
> 
>     soup_cookies_free(existingCookies);
> }
> 
>-void NetworkStorageSession::setCookies(const Vector<Cookie>& cookies, const URL&, const URL&)
>+void NetworkStorageSession::setCookies(const Vector<Cookie>& cookies, const URL& url, const URL& firstParty)
> {
>-    for (auto cookie : cookies)
>+    for (auto cookie : cookies) {
>+#if SOUP_CHECK_VERSION(2, 67, 1)
>+        GUniquePtr<SoupURI> origin = urlToSoupURI(url);
>+        GUniquePtr<SoupURI> firstPartyURI = urlToSoupURI(firstParty);
>+
>+        soup_cookie_jar_add_cookie_full(cookieStorage(), cookie.toSoupCookie(), origin.get(), firstPartyURI.get());
>+#else
>         soup_cookie_jar_add_cookie(cookieStorage(), cookie.toSoupCookie());
>+#endif
>+    }
> }
> 
> void NetworkStorageSession::setCookie(const Cookie& cookie)

Actions: View | Formatted Diff | Diff

Attachments on bug 169356: 371127 | 371135 | 385472