Attachment 371117 Details for Bug 198458 – Patch

[patch] Patch

bug-198458-20190601114704.patch (text/plain), 4.52 KB, created by Simon Fraser (smfr) on 2019-06-01 11:47:05 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Simon Fraser (smfr)

Created: 2019-06-01 11:47:05 PDT

Size: 4.52 KB

patch

obsolete

>Subversion Revision: 246008
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index a53f2d7be9a20183558adce080dace19ea046cc8..b5568f427968d781e3e831424191e0fcf736f6a7 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,18 @@
>+2019-06-01  Simon Fraser  <simon.fraser@apple.com>
>+
>+        [Async overflow scroll] Flashing content when scrolling async overflow with a negative z-index child
>+        https://bugs.webkit.org/show_bug.cgi?id=198458
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Set the GraphicsLayerPaintOverflowContents phase on the foreground layer in a composited overflow scroller,
>+        which prevents clipping to the visible region, fixing scrolling flashes.
>+
>+        Tested by compositing/overflow/stacking-context-composited-scroller-with-foreground-paint-phases.html
>+
>+        * rendering/RenderLayerBacking.cpp:
>+        (WebCore::RenderLayerBacking::updatePaintingPhases):
>+
> 2019-06-01  Simon Fraser  <simon.fraser@apple.com>
> 
>         Non-composited negative z-order children should not trigger creation of a foreground layer
>diff --git a/Source/WebCore/rendering/RenderLayerBacking.cpp b/Source/WebCore/rendering/RenderLayerBacking.cpp
>index 61fc70c32cc2ccf0ad82f4566cf4998e3dad7f27..19dfbb12cce6a4bc88e262edf2ea8a3b7e544ad3 100644
>--- a/Source/WebCore/rendering/RenderLayerBacking.cpp
>+++ b/Source/WebCore/rendering/RenderLayerBacking.cpp
>@@ -2100,6 +2100,10 @@ void RenderLayerBacking::updatePaintingPhases()
>     
>     if (m_foregroundLayer) {
>         OptionSet<GraphicsLayerPaintingPhase> foregroundLayerPhases { GraphicsLayerPaintingPhase::Foreground };
>+        
>+        if (m_scrolledContentsLayer)
>+            foregroundLayerPhases.add(GraphicsLayerPaintingPhase::OverflowContents);
>+
>         m_foregroundLayer->setPaintingPhase(foregroundLayerPhases);
>         primaryLayerPhases.remove(GraphicsLayerPaintingPhase::Foreground);
>     }
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 0a3d93af58b5d0a15d04bb52c537878333eea7bf..682672a0580f2ff8b48fd4d0e043add33895259a 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,13 @@
>+2019-06-01  Simon Fraser  <simon.fraser@apple.com>
>+
>+        [Async overflow scroll] Flashing content when scrolling async overflow with a negative z-index child
>+        https://bugs.webkit.org/show_bug.cgi?id=198458
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * compositing/overflow/stacking-context-composited-scroller-with-foreground-paint-phases-expected.txt:
>+        * platform/ios-wk2/compositing/overflow/stacking-context-composited-scroller-with-foreground-paint-phases-expected.txt:
>+
> 2019-06-01  Simon Fraser  <simon.fraser@apple.com>
> 
>         Non-composited negative z-order children should not trigger creation of a foreground layer
>diff --git a/LayoutTests/compositing/overflow/stacking-context-composited-scroller-with-foreground-paint-phases-expected.txt b/LayoutTests/compositing/overflow/stacking-context-composited-scroller-with-foreground-paint-phases-expected.txt
>index c2b0ba7ab4568ad4846c4c2e803f2889d0e61611..63099dcaaa04c96eafde443f22d49b7ffbfe3787 100644
>--- a/LayoutTests/compositing/overflow/stacking-context-composited-scroller-with-foreground-paint-phases-expected.txt
>+++ b/LayoutTests/compositing/overflow/stacking-context-composited-scroller-with-foreground-paint-phases-expected.txt
>@@ -54,6 +54,7 @@ Scrolled contents
>                       (drawsContent 1)
>                       (paintingPhases
>                         GraphicsLayerPaintForeground
>+                        GraphicsLayerPaintOverflowContents
>                         )
>                     )
>                   )
>diff --git a/LayoutTests/platform/ios-wk2/compositing/overflow/stacking-context-composited-scroller-with-foreground-paint-phases-expected.txt b/LayoutTests/platform/ios-wk2/compositing/overflow/stacking-context-composited-scroller-with-foreground-paint-phases-expected.txt
>index 11ea23c77a3feffec6ac8176807b4f8bdf2529a4..fb55b1f1fb733f9e14ecaf2ca78430ae1b5a0a94 100644
>--- a/LayoutTests/platform/ios-wk2/compositing/overflow/stacking-context-composited-scroller-with-foreground-paint-phases-expected.txt
>+++ b/LayoutTests/platform/ios-wk2/compositing/overflow/stacking-context-composited-scroller-with-foreground-paint-phases-expected.txt
>@@ -54,6 +54,7 @@ Scrolled contents
>                       (drawsContent 1)
>                       (paintingPhases
>                         GraphicsLayerPaintForeground
>+                        GraphicsLayerPaintOverflowContents
>                         )
>                     )
>                   )

Actions: View | Formatted Diff | Diff

Attachments on bug 198458: 371117