Attachment 371108 Details for Bug 198423 – Patch

[patch] Patch

bug-198423-20190531230245.patch (text/plain), 2.18 KB, created by Sihui Liu on 2019-05-31 23:02:46 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Sihui Liu

Created: 2019-05-31 23:02:46 PDT

Size: 2.18 KB

patch

obsolete

>Subversion Revision: 246011
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 7de47b5263f6a25de491a787dd514cbc7cb9bf41..2dee9a6523d19e5e48c395ca744b68082b79e378 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-05-31  Sihui Liu  <sihui_liu@apple.com>
>+
>+        [ Mac WK2 ] TestWebKitAPI.WKWebView.LocalStorageProcessCrashes is a flaky timeout when run locally.
>+        https://bugs.webkit.org/show_bug.cgi?id=198423
>+        <rdar://problem/51305247>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        IDBDatabase receives error event on network process crash, so we don't need to check it periodically.
>+
>+        * TestWebKitAPI/Tests/WebKitCocoa/local-storage-process-crashes.html:
>+
> 2019-05-31  Ryosuke Niwa  <rniwa@webkit.org>
> 
>         DragAndDropTests.DragImageLocationForLinkInSubframe fails on some iPad
>diff --git a/Tools/TestWebKitAPI/Tests/WebKitCocoa/local-storage-process-crashes.html b/Tools/TestWebKitAPI/Tests/WebKitCocoa/local-storage-process-crashes.html
>index e2dc4f23bd06a10c53bb8bbe7ffecd344f12c0d5..16d17f9829e187f48ed5639912d60de3f6c6d6ef 100644
>--- a/Tools/TestWebKitAPI/Tests/WebKitCocoa/local-storage-process-crashes.html
>+++ b/Tools/TestWebKitAPI/Tests/WebKitCocoa/local-storage-process-crashes.html
>@@ -3,17 +3,6 @@
> 
> var db;
> 
>-function put() {
>-    var os = db.transaction(["TestObjectStore"], "readwrite").objectStore("TestObjectStore");
>-    var request = os.put('value', 'key');
>-    request.onsuccess = (event) => {
>-        setTimeout(put, 100);
>-    }
>-    request.onerror = (event)=> {
>-        window.webkit.messageHandlers.testHandler.postMessage("Network Process Crashed");
>-    }
>-}
>-
> window.localStorage.setItem("local", "storage");
> window.sessionStorage.setItem("session", "storage");
> 
>@@ -22,7 +11,7 @@ request.onsuccess = function(event) {
>     window.webkit.messageHandlers.testHandler.postMessage("local:" + window.localStorage.getItem("local"));
>     window.webkit.messageHandlers.testHandler.postMessage("session:"+ window.sessionStorage.getItem("session"));
>     db = request.result;
>-    put();
>+    db.onerror = () => window.webkit.messageHandlers.testHandler.postMessage("Network Process Crashed");
> }
> 
> request.onupgradeneeded = function(event) {

Actions: View | Formatted Diff | Diff

Attachments on bug 198423: 371087 | 371108