Attachment 371094 Details for Bug 198434 – Patch

[patch] Patch

bug-198434-20190531161528.patch (text/plain), 1.85 KB, created by youenn fablet on 2019-05-31 16:15:29 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2019-05-31 16:15:29 PDT

Size: 1.85 KB

patch

obsolete

>Subversion Revision: 245849
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 61f6559c83cb1fc3433b7395824f7de31dae0eff..3a35777fa011e75eff06c95e6ae3ca4c66643856 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-05-31  Youenn Fablet  <youenn@apple.com>
>+
>+        REGRESSION (r245913) [ Debug ] ASSERTION FAILED: m_swConnectionsByIdentifier.contains(connection.serverConnectionIdentifier()) Layout Test http/wpt/service-workers/update-service-worker.https.html is a flaky crash
>+        https://bugs.webkit.org/show_bug.cgi?id=198434
>+        <rdar://problem/51313917>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Iterate through the connectionID-based connection map instead of the sessionID-based map
>+        to notify them their connection is lost.
>+
>+        * WebProcess/Network/NetworkProcessConnection.cpp:
>+        (WebKit::NetworkProcessConnection::didClose):
>+
> 2019-05-30  Youenn Fablet  <youenn@apple.com>
> 
>         REGRESSION (r245873) [Mac WK2] Layout Test http/wpt/service-workers/update-service-worker.https.html is a flaky crash after running new test
>diff --git a/Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp b/Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp
>index 161f8da41fa86e611fd943107dfe6f63640c3e2e..619ea457515a02e25452b0348a7cbdd6c37262c0 100644
>--- a/Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp
>+++ b/Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp
>@@ -195,8 +195,8 @@ void NetworkProcessConnection::didClose(IPC::Connection&)
> #endif
> 
> #if ENABLE(SERVICE_WORKER)
>-    m_swConnectionsByIdentifier.clear();
>-    for (auto& connection : m_swConnectionsBySession.values())
>+    auto connections = WTFMove(m_swConnectionsByIdentifier);
>+    for (auto& connection : connections.values())
>         connection->connectionToServerLost();
> #endif
> }

Actions: View | Formatted Diff | Diff

Attachments on bug 198434: 371094 | 371244