Attachment 371093 Details for Bug 198433 – WIP

[patch] WIP

patch.diff (text/plain), 1.38 KB, created by Saam Barati on 2019-05-31 15:48:09 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Saam Barati

Created: 2019-05-31 15:48:09 PDT

Size: 1.38 KB

patch

obsolete

>Index: Source/WebCore/Modules/webgpu/WHLSL/Metal/WHLSLEntryPointScaffolding.cpp
>===================================================================
>--- Source/WebCore/Modules/webgpu/WHLSL/Metal/WHLSLEntryPointScaffolding.cpp	(revision 245951)
>+++ Source/WebCore/Modules/webgpu/WHLSL/Metal/WHLSLEntryPointScaffolding.cpp	(working copy)
>@@ -248,8 +248,14 @@ String EntryPointScaffolding::mangledOut
> String EntryPointScaffolding::unpackResourcesAndNamedBuiltIns()
> {
>     StringBuilder stringBuilder;
>-    for (size_t i = 0; i < m_functionDefinition.parameters().size(); ++i)
>-        stringBuilder.append(makeString(m_typeNamer.mangledNameForType(*m_functionDefinition.parameters()[i]->type()), ' ', m_parameterVariables[i], ";\n"));
>+    for (size_t i = 0; i < m_functionDefinition.parameters().size(); ++i) {
>+        auto typeName = m_typeNamer.mangledNameForType(*m_functionDefinition.parameters()[i]->type());
>+        stringBuilder.append(makeString(typeName, ' ', m_parameterVariables[i], ";\n"));
>+        stringBuilder.append(makeString("for (size_t i = 0; i < sizeof(", typeName, "); ++i) {\n"));
>+        stringBuilder.append(makeString("    static_cast<thread char*>(static_cast<thread void*>(&", m_parameterVariables[i], "))[i] = 0;\n"));
>+        stringBuilder.append("}\n");
>+    }
> 
>     for (size_t i = 0; i < m_layout.size(); ++i) {
>         auto variableName = m_namedBindGroups[i].variableName;

Actions: View | Formatted Diff | Diff

Attachments on bug 198433: 371093 | 372620