Attachment 371071 Details for Bug 197894 – Patch

[patch] Patch

bug-197894-20190531110338.patch (text/plain), 1.65 KB, created by Andres Gonzalez on 2019-05-31 11:03:39 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Andres Gonzalez

Created: 2019-05-31 11:03:39 PDT

Size: 1.65 KB

patch

obsolete

>Subversion Revision: 245972
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 85b6627fc5fd956766ae6678e372dbb0975e904a..b73022f0117b5fc615e0a9d8a9e64d2f7e64d022 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,18 @@
>+2019-05-31  Andres Gonzalez  <andresg_22@apple.com>
>+
>+        Inserting a newline in contenteditable causes two characters to be added instead of one
>+        https://bugs.webkit.org/show_bug.cgi?id=197894
>+        <rdar://problems/49700998>
>+
>+        Reviewed by Chris Fleizach.
>+
>+        No new test is necessary since this is a comment change.
>+
>+        Removed radar reference from code.
>+
>+        * editing/Editing.cpp:
>+        (WebCore::visiblePositionForIndexUsingCharacterIterator):
>+
> 2019-05-31  Geoffrey Garen  <ggaren@apple.com>
> 
>         Some WeakPtr cleanup
>diff --git a/Source/WebCore/editing/Editing.cpp b/Source/WebCore/editing/Editing.cpp
>index 25450fc14f5c1f50d6bf75258a65c385070897a6..89440fe1abb7f82a8e99b05a89a5b6fc00acfbcb 100644
>--- a/Source/WebCore/editing/Editing.cpp
>+++ b/Source/WebCore/editing/Editing.cpp
>@@ -1123,7 +1123,7 @@ VisiblePosition visiblePositionForIndexUsingCharacterIterator(Node& node, int in
>     it.advance(index - 1);
> 
>     if (!it.atEnd() && it.text()[0] == '\n') {
>-        // FIXME: workaround for collapsed range (where only start position is correct) emitted for some emitted newlines (see rdar://5192593)
>+        // FIXME: workaround for collapsed range (where only start position is correct) emitted for some emitted newlines.
>         auto range = it.range();
>         if (range->startPosition() == range->endPosition()) {
>             it.advance(1);

Actions: View | Formatted Diff | Diff

Attachments on bug 197894: 369892 | 369907 | 370014 | 370023 | 370028 | 370032 | 370116 | 370120 | 370121 | 370419 | 370435 | 370575 | 370964 | 370981 | 371007 | 371071