Attachment 371061 Details for Bug 194808 – Patch

[patch] Patch

bug-194808-20190531090852.patch (text/plain), 1.68 KB, created by Alex Christensen on 2019-05-31 09:08:52 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Christensen

Created: 2019-05-31 09:08:52 PDT

Size: 1.68 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 245964)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,17 @@
>+2019-05-31  Alex Christensen  <achristensen@webkit.org>
>+
>+        REGRESSION (Safari 12): SafariForWebkitDevelopment won't load any pages on Mojave, nightly builds broken
>+        https://bugs.webkit.org/show_bug.cgi?id=194808
>+        <rdar://problem/48278497>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        I verified that a daily build downloaded an run on Mojave does not work without this and works with this.
>+
>+        * WebKitArchiveSupport/run-webkit-archive:
>+        (set_dyld_framework_path):
>+        Also set XPC variants of needed environment variables.
>+
> 2019-05-31  Carlos Garcia Campos  <cgarcia@igalia.com>
> 
>         [WPE] Build at-spi2-core without x11 support in jhbuild
>Index: Tools/WebKitArchiveSupport/run-webkit-archive
>===================================================================
>--- Tools/WebKitArchiveSupport/run-webkit-archive	(revision 245825)
>+++ Tools/WebKitArchiveSupport/run-webkit-archive	(working copy)
>@@ -54,6 +54,8 @@ def set_dyld_framework_path(script_path)
>     print('Setting DYLD FRAMEWORK and LIBRARY paths to {}'.format(dyld_path))
>     os.environ['DYLD_FRAMEWORK_PATH'] = dyld_path
>     os.environ['DYLD_LIBRARY_PATH'] = dyld_path
>+    os.environ['__XPC_DYLD_FRAMEWORK_PATH'] = dyld_path
>+    os.environ['__XPC_DYLD_LIBRARY_PATH'] = dyld_path
>     
> def main():
>     check_for_valid_platform()
>@@ -66,4 +68,4 @@ if __name__ == '__main__':
>     try:
>         main()    
>     except KeyboardInterrupt:
>-        exit("Aborting.")
>\ No newline at end of file
>+        exit("Aborting.")

Flags:

darin: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 194808: 362500 | 362501 | 362502 | 362503 | 362511 | 371061