Attachment 371021 Details for Bug 198394 – Patch

[patch] Patch

bug-198394-20190530192813.patch (text/plain), 1.44 KB, created by Devin Rousso on 2019-05-30 19:28:13 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Devin Rousso

Created: 2019-05-30 19:28:13 PDT

Size: 1.44 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index f176cf6d8db264e6ed98d4cd7f9cd96443e7fe77..7a42e95389702a539d0989c47438a4b679de96af 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-05-30  Devin Rousso  <drousso@apple.com>
>+
>+        Web Inspector: Timelines: CPU: gray (?) and (x) should be white
>+        https://bugs.webkit.org/show_bug.cgi?id=198394
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/Variables.css:
>+        (@media (prefers-color-scheme: dark)):
>+        Remove the dark mode override for `--gray-foreground-color`, as the default `white` is a
>+        better contrast.
>+
> 2019-05-30  Devin Rousso  <drousso@apple.com>
> 
>         Web Inspector: Audit: there should be a default test for WebInspectorAudit.Resources functionality
>diff --git a/Source/WebInspectorUI/UserInterface/Views/Variables.css b/Source/WebInspectorUI/UserInterface/Views/Variables.css
>index fe884fcba0ac9df94d1f2ef20fcdee8ae7768a97..b082b5c8a0edce59c291f8f2f638f8cc5289fcde 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/Variables.css
>+++ b/Source/WebInspectorUI/UserInterface/Views/Variables.css
>@@ -229,7 +229,6 @@ body.window-inactive * {
>         --background-color-code: hsl(0, 0%, 21%);
> 
>         --gray-background-color: hsl(0, 0%, 50%);
>-        --gray-foreground-color: hsl(0, 0%, 33%);
> 
>         --link-text-color: var(--text-color-secondary);
>

Actions: View | Formatted Diff | Diff

Attachments on bug 198394: 371021