Attachment 370934 Details for Bug 198369 – Patch

[patch] Patch

wkgtk-wpe-leak.diff (text/plain), 1.39 KB, created by Carlos Garcia Campos on 2019-05-30 03:40:04 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Carlos Garcia Campos

Created: 2019-05-30 03:40:04 PDT

Size: 1.39 KB

patch

obsolete

>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 660d0da1005..58790ccf210 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-05-30  Carlos Garcia Campos  <cgarcia@igalia.com>
>+
>+        [GTK] Fix memory leak introduced in r245807
>+        https://bugs.webkit.org/show_bug.cgi?id=198369
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        We should destroy the wpe_view_backend_exportable_fdo created in AcceleratedBackingStoreWayland.
>+
>+        * UIProcess/gtk/AcceleratedBackingStoreWayland.cpp:
>+        (WebKit::AcceleratedBackingStoreWayland::~AcceleratedBackingStoreWayland):
>+
> 2019-05-30  Carlos Garcia Campos  <cgarcia@igalia.com>
> 
>         REGRESSION(r244182): [GTK] Web view no longer updated after re-entering AC mode
>diff --git a/Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreWayland.cpp b/Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreWayland.cpp
>index e643daebfc0..a242d70de60 100644
>--- a/Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreWayland.cpp
>+++ b/Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreWayland.cpp
>@@ -132,6 +132,7 @@ AcceleratedBackingStoreWayland::~AcceleratedBackingStoreWayland()
>         if (makeContextCurrent())
>             glDeleteTextures(1, &m_viewTexture);
>     }
>+    wpe_view_backend_exportable_fdo_destroy(m_exportable);
> #else
>     WaylandCompositor::singleton().unregisterWebPage(m_webPage);
> #endif

Flags:

mcatanzaro: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 198369: 370934 | 370941