Attachment 370932 Details for Bug 198367 – Patch

[patch] Patch

wkgtk-re-enter-ac-freeze.diff (text/plain), 2.09 KB, created by Carlos Garcia Campos on 2019-05-30 03:24:04 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Carlos Garcia Campos

Created: 2019-05-30 03:24:04 PDT

Size: 2.09 KB

patch

obsolete

>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index ec7145a6e15..660d0da1005 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,19 @@
>+2019-05-30  Carlos Garcia Campos  <cgarcia@igalia.com>
>+
>+        REGRESSION(r244182): [GTK] Web view no longer updated after re-entering AC mode
>+        https://bugs.webkit.org/show_bug.cgi?id=198367
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This happens because we leave accelerated compositing mode when a rendering update is scheduled in
>+        RenderingUpdateScheduler. The threaded compositor display refresh monitor is destroyed without completing the
>+        frame, so that the RenderingUpdateScheduler is left scheduled forever, ignoring any new schedule request. We
>+        need to ensure we complete the frame request before destrying the display refresh monitor to leave the
>+        RenderingUpdateScheduler in a consistent state.
>+
>+        * Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.cpp:
>+        (WebKit::ThreadedDisplayRefreshMonitor::invalidate):
>+
> 2019-05-27  Carlos Garcia Campos  <cgarcia@igalia.com>
> 
>         [GTK] Use WPEBackend-fdo for accelerating compositing in Wayland instead of the nested compositor
>diff --git a/Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.cpp b/Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.cpp
>index 8638f9e3abb..e56f22b333f 100644
>--- a/Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.cpp
>+++ b/Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.cpp
>@@ -85,6 +85,13 @@ void ThreadedDisplayRefreshMonitor::dispatchDisplayRefreshCallback()
> void ThreadedDisplayRefreshMonitor::invalidate()
> {
>     m_displayRefreshTimer.stop();
>+    bool wasScheduled = false;
>+    {
>+        LockHolder locker(mutex());
>+        wasScheduled = isScheduled();
>+    }
>+    if (wasScheduled)
>+        DisplayRefreshMonitor::handleDisplayRefreshedNotificationOnMainThread(this);
>     m_client = nullptr;
> }
>

Flags:

svillar: review+
ews-watchlist: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 198367: 370932 | 371008