WebKit Bugzilla
Attachment 370895 Details for
Bug 198322
: Attempt to fix JSC test timeouts after adding collectContinuously to WASM tests.
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-198322-20190529161809.patch (text/plain), 3.47 KB, created by
Justin Michaud
on 2019-05-29 16:18:09 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Justin Michaud
Created:
2019-05-29 16:18:09 PDT
Size:
3.47 KB
patch
obsolete
>Subversion Revision: 245869 >diff --git a/Tools/ChangeLog b/Tools/ChangeLog >index be614c1f4723f5668cb184ffab739f324572f485..754d291ba48ab8ab1b32a49e4054013b1d1f34ac 100644 >--- a/Tools/ChangeLog >+++ b/Tools/ChangeLog >@@ -1,3 +1,13 @@ >+2019-05-29 Justin Michaud <justin_michaud@apple.com> >+ >+ Attempt to fix JSC test timeouts after adding collectContinuously to WASM tests. >+ https://bugs.webkit.org/show_bug.cgi?id=198322 >+ >+ Rubber-stamped by Michael Saboff. Disable running the new collectContinuously tests on debug builds. >+ This matches what we do for other jsc tests. >+ >+ * Scripts/run-jsc-stress-tests: >+ > 2019-05-29 Geoffrey Garen <ggaren@apple.com> > > WeakPtr breaks vtables when upcasting to base classes >diff --git a/Tools/Scripts/run-jsc-stress-tests b/Tools/Scripts/run-jsc-stress-tests >index 91494646144503db9fb4e71a10849a18b29201e6..123b7fd4ddc29fb925d3573bb29b8052b3e6dba1 100755 >--- a/Tools/Scripts/run-jsc-stress-tests >+++ b/Tools/Scripts/run-jsc-stress-tests >@@ -1081,7 +1081,7 @@ def runWebAssembly > run("wasm-no-tls-context", "-m", "--useFastTLSForWasmContext=false", *FTL_OPTIONS) > run("wasm-slow-memory", "-m", "--useWebAssemblyFastMemory=false", *FTL_OPTIONS) > run("wasm-no-air", "-m", "--wasmBBQUsesAir=false", *FTL_OPTIONS) >- run("wasm-collect-continuously", "-m", "--collectContinuously=true", "--collectContinuouslyPeriodMS=1.3", *FTL_OPTIONS) >+ run("wasm-collect-continuously", "-m", "--collectContinuously=true", *FTL_OPTIONS) if shouldCollectContinuously? > end > end > >@@ -1099,7 +1099,7 @@ def runWebAssemblySuite > run("wasm-no-tls-context", "-m", "--useFastTLSForWasmContext=false", *FTL_OPTIONS) > run("wasm-slow-memory", "-m", "--useWebAssemblyFastMemory=false", *FTL_OPTIONS) > run("wasm-no-air", "-m", "--wasmBBQUsesAir=false", *FTL_OPTIONS) >- run("wasm-collect-continuously", "-m", "--collectContinuously=true", "--collectContinuouslyPeriodMS=1.3", *FTL_OPTIONS) >+ run("wasm-collect-continuously", "-m", "--collectContinuously=true", *FTL_OPTIONS) if shouldCollectContinuously? > end > end > >@@ -1119,7 +1119,7 @@ def runWebAssemblyEmscripten(mode) > run("wasm-no-call-ic", "--useCallICsForWebAssemblyToJSCalls=false", *FTL_OPTIONS) > run("wasm-no-tls-context", "--useFastTLSForWasmContext=false", *FTL_OPTIONS) > run("wasm-no-air", "--wasmBBQUsesAir=false", *FTL_OPTIONS) >- run("wasm-collect-continuously", "--collectContinuously=true", "--collectContinuouslyPeriodMS=1.3", *FTL_OPTIONS) >+ run("wasm-collect-continuously", "--collectContinuously=true", *FTL_OPTIONS) if shouldCollectContinuously? > end > end > >@@ -1145,7 +1145,7 @@ def runWebAssemblySpecTest(mode) > runWithOutputHandler("wasm-no-call-ic", noisyOutputHandler, "../spec-harness.js", "--useCallICsForWebAssemblyToJSCalls=false", *FTL_OPTIONS) > runWithOutputHandler("wasm-no-tls-context", noisyOutputHandler, "../spec-harness.js", "--useFastTLSForWasmContext=false", *FTL_OPTIONS) > runWithOutputHandler("wasm-no-air", noisyOutputHandler, "../spec-harness.js", "--wasmBBQUsesAir=false", *FTL_OPTIONS) >- runWithOutputHandler("wasm-collect-continuously", noisyOutputHandler, "../spec-harness.js", "--collectContinuously=true", "--collectContinuouslyPeriodMS=1.3", *FTL_OPTIONS) >+ runWithOutputHandler("wasm-collect-continuously", noisyOutputHandler, "../spec-harness.js", "--collectContinuously=true", *FTL_OPTIONS) if shouldCollectContinuously? > end > end >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 198322
:
370822
|
370824
| 370895