Attachment 370890 Details for Bug 198352 – Patch

[patch] Patch

198352.1.diff (text/plain), 2.46 KB, created by Stephan Szabo on 2019-05-29 15:46:00 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Stephan Szabo

Created: 2019-05-29 15:46:00 PDT

Size: 2.46 KB

patch

obsolete

>diff --git a/JSTests/ChangeLog b/JSTests/ChangeLog
>index c663fee0417..49aef4a22c6 100644
>--- a/JSTests/ChangeLog
>+++ b/JSTests/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-05-29  Stephan Szabo  <stephan.szabo@sony.com>
>+
>+        [PlayStation] Skip additional tests on PlayStation
>+        https://bugs.webkit.org/show_bug.cgi?id=198352
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Skip pow test on PlayStation due to behavior difference in standard library.
>+        Skip incremental marking test due to OOM on PlayStation systems.
>+
>+        * stress/incremental-marking-should-not-dead-lock-in-new-property-transition.js:
>+        * stress/math-pow-with-constants.js:
>+        * stress/pow-with-constants.js:
>+
> 2019-05-28  Tadeu Zagallo  <tzagallo@apple.com>
> 
>         JITOperations putByVal should mark negative array indices as out-of-bounds
>diff --git a/JSTests/stress/incremental-marking-should-not-dead-lock-in-new-property-transition.js b/JSTests/stress/incremental-marking-should-not-dead-lock-in-new-property-transition.js
>index aa3e1ca7998..38c275739a5 100644
>--- a/JSTests/stress/incremental-marking-should-not-dead-lock-in-new-property-transition.js
>+++ b/JSTests/stress/incremental-marking-should-not-dead-lock-in-new-property-transition.js
>@@ -1,3 +1,4 @@
>+//@ skip if $hostOS == "playstation"
> //@ runDefault("--gcIncrementScale=100", "--gcIncrementBytes=10", "--numberOfGCMarkers=1")
> 
> let a = [];
>diff --git a/JSTests/stress/math-pow-with-constants.js b/JSTests/stress/math-pow-with-constants.js
>index 090f5b7728c..c2fb0135cbc 100644
>--- a/JSTests/stress/math-pow-with-constants.js
>+++ b/JSTests/stress/math-pow-with-constants.js
>@@ -1,3 +1,6 @@
>++// FIXME: unskip when playstation's pow() matches other platforms
>++//@ skip if $hostOS == "playstation"
>+
> function exponentIsZero(x) {
>     return Math.pow(x, 0);
> }
>@@ -282,4 +285,4 @@ function testExponentIsNegativeInfinityConstant() {
>             throw "Error: exponentIsNegativeInfinityConstant(2.1) should be zero, was = " + result;
>     }
> }
>-testExponentIsNegativeInfinityConstant();
>\ No newline at end of file
>+testExponentIsNegativeInfinityConstant();
>diff --git a/JSTests/stress/pow-with-constants.js b/JSTests/stress/pow-with-constants.js
>index 79e6af741d1..3c3bcc76f94 100644
>--- a/JSTests/stress/pow-with-constants.js
>+++ b/JSTests/stress/pow-with-constants.js
>@@ -1,3 +1,6 @@
>+// FIXME: unskip when playstation's pow() matches other platforms
>+//@ skip if $hostOS == "playstation"
>+
> function exponentIsZero(x) {
>     return x ** 0;
> }

Actions: View | Formatted Diff | Diff

Attachments on bug 198352: 370890 | 370898 | 370903