Attachment 370866 Details for Bug 198342 – Patch

[patch] Patch

bug-198342-20190529110504.patch (text/plain), 1.80 KB, created by Keith Rollin on 2019-05-29 11:05:05 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Keith Rollin

Created: 2019-05-29 11:05:05 PDT

Size: 1.80 KB

patch

obsolete

>Subversion Revision: 245817
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index a5b3cf9b0989a879872eacedce7ad32361f4135f..9b6e74fd7c208ca3cf48f9fd3b3097fdbdfc809b 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,19 @@
>+2019-05-29  Keith Rollin  <krollin@apple.com>
>+
>+        Fix builds that don't use makeWindowFromView
>+        https://bugs.webkit.org/show_bug.cgi?id=198342
>+        <rdar://problem/51228563>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        In some configurations, VideoFullscreenInterfaceAVKit.mm declares but
>+        does not use makeWindowFromView. Fix by conditionalizing the the
>+        declaration on the same symbol as point where it's used.
>+
>+        No new tests -- no new functionality.
>+
>+        * platform/ios/VideoFullscreenInterfaceAVKit.mm:
>+
> 2019-05-28  Zalan Bujtas  <zalan@apple.com>
> 
>         [LFC][Verification] Add additional inline and block checks
>diff --git a/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm b/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm
>index bfc084d2df28d4f36d2a5f8f4e3773922571fa3a..cba04184af02d302dd2a19ec5b0b2fefb441a23c 100644
>--- a/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm
>+++ b/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm
>@@ -1177,6 +1177,7 @@ void VideoFullscreenInterfaceAVKit::setInlineRect(const IntRect& inlineRect, boo
>         doExitFullscreen();
> }
> 
>+#if !PLATFORM(WATCHOS)
> #if USE(APPLE_INTERNAL_SDK)
> #import <WebKitAdditions/VideoFullscreenInterfaceAVKitAdditions.mm>
> #else
>@@ -1185,6 +1186,7 @@ static RetainPtr<UIWindow> makeWindowFromView(UIView *)
>     return adoptNS([PAL::allocUIWindowInstance() initWithFrame:[[PAL::getUIScreenClass() mainScreen] bounds]]);
> }
> #endif
>+#endif
> 
> void VideoFullscreenInterfaceAVKit::doSetup()
> {

Actions: View | Formatted Diff | Diff

Attachments on bug 198342: 370866