Attachment 370847 Details for Bug 198331 – Patch

[patch] Patch

bug-198331-20190529165553.patch (text/plain), 1.76 KB, created by Ludovico de Nittis on 2019-05-29 07:55:54 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ludovico de Nittis

Created: 2019-05-29 07:55:54 PDT

Size: 1.76 KB

patch

obsolete

>Subversion Revision: 245849
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index a208d52bc4eda0f16355272164410063e59650f5..a5873a257221883fc03fae7b34e2380c7e00ce86 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,19 @@
>+2019-05-29  Ludovico de Nittis  <ludovico.denittis@collabora.com>
>+
>+        Prepend KEY_ to the last key alias in PlatformEventKeyboardGtk
>+        https://bugs.webkit.org/show_bug.cgi?id=198331
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        No behavior change.
>+
>+        With the commit
>+        https://bugs.webkit.org/show_bug.cgi?id=198326
>+        A gdk key slipped away from the renaming.
>+
>+        * platform/gtk/PlatformKeyboardEventGtk.cpp:
>+        (WebCore::modifiersForGdkKeyEvent):
>+
> 2019-05-29  Ludovico de Nittis  <ludovico.denittis@collabora.com>
> 
>         PlatformEventKeyboardGtk still uses old key aliases
>diff --git a/Source/WebCore/platform/gtk/PlatformKeyboardEventGtk.cpp b/Source/WebCore/platform/gtk/PlatformKeyboardEventGtk.cpp
>index 2030a862a171ddb5ab92262423898b3621d976bb..5b67a59cb0c3852cb1609989258e5799754f4bc8 100644
>--- a/Source/WebCore/platform/gtk/PlatformKeyboardEventGtk.cpp
>+++ b/Source/WebCore/platform/gtk/PlatformKeyboardEventGtk.cpp
>@@ -1330,7 +1330,7 @@ static PlatformEvent::Type eventTypeForGdkKeyEvent(GdkEventKey* event)
> static OptionSet<PlatformEvent::Modifier> modifiersForGdkKeyEvent(GdkEventKey* event)
> {
>     OptionSet<PlatformEvent::Modifier> modifiers;
>-    if (event->state & GDK_SHIFT_MASK || event->keyval == GDK_3270_BackTab)
>+    if (event->state & GDK_SHIFT_MASK || event->keyval == GDK_KEY_3270_BackTab)
>         modifiers.add(PlatformEvent::Modifier::ShiftKey);
>     if (event->state & GDK_CONTROL_MASK)
>         modifiers.add(PlatformEvent::Modifier::ControlKey);

Actions: View | Formatted Diff | Diff

Attachments on bug 198331: 370847