Attachment 370824 Details for Bug 198322 – patch

[patch] patch

bug-198322-20190528190550.patch (text/plain), 3.43 KB, created by Justin Michaud on 2019-05-28 19:49:00 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Justin Michaud

Created: 2019-05-28 19:49:00 PDT

Size: 3.43 KB

patch

obsolete

>Subversion Revision: 245818
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 44b0c5c7b48ffc762bcd94c9f85fa514f4def60c..0ea2175581c760363c980d6ce8d79297e4b863bd 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-05-28  Justin Michaud  <justin_michaud@apple.com>
>+
>+        Attempt to fix JSC test timeouts after adding collectContinuously to WASM tests.
>+        https://bugs.webkit.org/show_bug.cgi?id=198322
>+
>+        Reviewed by Saam Barati.
>+
>+        Increases the collection period from 1 to slightly higher to try to speed up the tests. Any higher and
>+        the test runner does not detect the bug that required the memset in Wasm::Instance::Instance().
>+
>+        * Scripts/run-jsc-stress-tests:
>+
> 2019-05-28  Aakash Jain  <aakash_jain@apple.com>
> 
>         [ews-build] Remove unused buildbot tabs
>diff --git a/Tools/Scripts/run-jsc-stress-tests b/Tools/Scripts/run-jsc-stress-tests
>index 028c16ad9b1b01404e73a89dd6758c99a7ebbf48..91494646144503db9fb4e71a10849a18b29201e6 100755
>--- a/Tools/Scripts/run-jsc-stress-tests
>+++ b/Tools/Scripts/run-jsc-stress-tests
>@@ -1081,7 +1081,7 @@ def runWebAssembly
>         run("wasm-no-tls-context", "-m", "--useFastTLSForWasmContext=false", *FTL_OPTIONS)
>         run("wasm-slow-memory", "-m", "--useWebAssemblyFastMemory=false", *FTL_OPTIONS)
>         run("wasm-no-air", "-m", "--wasmBBQUsesAir=false", *FTL_OPTIONS)
>-        run("wasm-collect-continuously", "-m", "--collectContinuously=true", *FTL_OPTIONS)
>+        run("wasm-collect-continuously", "-m", "--collectContinuously=true", "--collectContinuouslyPeriodMS=1.3", *FTL_OPTIONS)
>     end
> end
> 
>@@ -1099,7 +1099,7 @@ def runWebAssemblySuite
>         run("wasm-no-tls-context", "-m", "--useFastTLSForWasmContext=false", *FTL_OPTIONS)
>         run("wasm-slow-memory", "-m", "--useWebAssemblyFastMemory=false", *FTL_OPTIONS)
>         run("wasm-no-air", "-m", "--wasmBBQUsesAir=false", *FTL_OPTIONS)
>-        run("wasm-collect-continuously", "-m", "--collectContinuously=true", *FTL_OPTIONS)
>+        run("wasm-collect-continuously", "-m", "--collectContinuously=true", "--collectContinuouslyPeriodMS=1.3", *FTL_OPTIONS)
>     end
> end
> 
>@@ -1119,7 +1119,7 @@ def runWebAssemblyEmscripten(mode)
>         run("wasm-no-call-ic", "--useCallICsForWebAssemblyToJSCalls=false", *FTL_OPTIONS)
>         run("wasm-no-tls-context", "--useFastTLSForWasmContext=false", *FTL_OPTIONS)
>         run("wasm-no-air", "--wasmBBQUsesAir=false", *FTL_OPTIONS)
>-        run("wasm-collect-continuously", "--collectContinuously=true", *FTL_OPTIONS)
>+        run("wasm-collect-continuously", "--collectContinuously=true", "--collectContinuouslyPeriodMS=1.3", *FTL_OPTIONS)
>     end
> end
> 
>@@ -1145,7 +1145,7 @@ def runWebAssemblySpecTest(mode)
>       runWithOutputHandler("wasm-no-call-ic", noisyOutputHandler, "../spec-harness.js", "--useCallICsForWebAssemblyToJSCalls=false", *FTL_OPTIONS)
>       runWithOutputHandler("wasm-no-tls-context", noisyOutputHandler, "../spec-harness.js", "--useFastTLSForWasmContext=false", *FTL_OPTIONS)
>       runWithOutputHandler("wasm-no-air", noisyOutputHandler, "../spec-harness.js", "--wasmBBQUsesAir=false", *FTL_OPTIONS)
>-      runWithOutputHandler("wasm-collect-continuously", noisyOutputHandler, "../spec-harness.js", "--collectContinuously=true", *FTL_OPTIONS)
>+      runWithOutputHandler("wasm-collect-continuously", noisyOutputHandler, "../spec-harness.js", "--collectContinuously=true", "--collectContinuouslyPeriodMS=1.3", *FTL_OPTIONS)
>     end
> end
>

Actions: View | Formatted Diff | Diff

Attachments on bug 198322: 370822 | 370824 | 370895