Attachment 370723 Details for Bug 198290 – Patch

[patch] Patch

bug-198290-20190528194502.patch (text/plain), 1.84 KB, created by Fujii Hironori on 2019-05-28 03:45:03 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Fujii Hironori

Created: 2019-05-28 03:45:03 PDT

Size: 1.84 KB

patch

obsolete

>Subversion Revision: 245808
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index aa16305455170acbdd27169e9ee53c8f5d364b2a..a86199fec3149faf9d66e350119037914a023886 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-05-28  Fujii Hironori  <Hironori.Fujii@sony.com>
>+
>+        [WinCairo][MediaFoundation] Assertion failure in MediaPlayerPrivateMediaFoundation::Direct3DPresenter::presentSample
>+        https://bugs.webkit.org/show_bug.cgi?id=198290
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Covered by existing tests.
>+
>+        * platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:
>+        (WebCore::MediaPlayerPrivateMediaFoundation::Direct3DPresenter::presentSample):
>+        Call clear() of m_memSurface before assigning new value.
>+
> 2019-05-28  Fujii Hironori  <Hironori.Fujii@sony.com>
> 
>         [WinCairo] ASSERTION FAILED: !m_preparingToPlay in MediaPlayerPrivateMediaFoundation::prepareToPlay
>diff --git a/Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp b/Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp
>index a39b59217e6500011501e9cceb18d09ebf3b0e75..00b0d0884fc282b1c7f226ecd6ae507a0a6f85ee 100644
>--- a/Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp
>+++ b/Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp
>@@ -2889,6 +2889,7 @@ HRESULT MediaPlayerPrivateMediaFoundation::Direct3DPresenter::presentSample(IMFS
>                 D3DSURFACE_DESC desc;
>                 if (SUCCEEDED(surface->GetDesc(&desc)))
>                     format = desc.Format;
>+                m_memSurface.clear();
>                 hr = m_device->CreateOffscreenPlainSurface(width, height, format, D3DPOOL_SYSTEMMEM, &m_memSurface, nullptr);
>                 m_width = width;
>                 m_height = height;

Flags:

pvollan: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 198290: 370721 | 370722 | 370723