Attachment 370625 Details for Bug 198244 – WIP

[patch] WIP

wip198244b.patch (text/plain), 1.53 KB, created by Ryosuke Niwa on 2019-05-24 23:50:37 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ryosuke Niwa

Created: 2019-05-24 23:50:37 PDT

Size: 1.53 KB

patch

obsolete

>
>diff --git a/Source/WebCore/page/FrameView.cpp b/Source/WebCore/page/FrameView.cpp
>index fcdef0cce2f..85dce94ebe2 100644
>--- a/Source/WebCore/page/FrameView.cpp
>+++ b/Source/WebCore/page/FrameView.cpp
>@@ -662,7 +662,12 @@ void FrameView::applyOverflowToViewport(const RenderElement& renderer, Scrollbar
>     // there is a frameScaleFactor that is greater than one on the main frame. Also disregard hidden if there is a
>     // header or footer.
> 
>-    bool overrideHidden = frame().isMainFrame() && ((frame().frameScaleFactor() > 1) || headerHeight() || footerHeight());
>+    bool overrideHidden = false;
>+    if (frame().isMainFrame()) {
>+        // FIXME: There can be off by one error in frameview's scroll position when rubberbanding.
>+        if (frame().frameScaleFactor() > 1 || headerHeight() || footerHeight() || visualViewportRect().size() != layoutViewportRect().size())
>+            overrideHidden = true;
>+    }
> 
>     Overflow overflowX = renderer.style().overflowX();
>     Overflow overflowY = renderer.style().overflowY();
>@@ -2776,6 +2781,14 @@ void FrameView::didUpdateViewportOverrideRects()
> 
>     if (auto* window = frame().window())
>         window->visualViewport().update();
>+
>+    if (layoutContext().didFirstLayout()) {
>+        ScrollbarMode hMode;
>+        ScrollbarMode vMode;
>+        calculateScrollbarModesForLayout(hMode, vMode);
>+        if (hMode != horizontalScrollbarMode() || vMode != verticalScrollbarMode())
>+            setNeedsLayoutAfterViewConfigurationChange();
>+    }
> }
> 
> void FrameView::unobscuredContentSizeChanged()

Flags:

ews-watchlist: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 198244: 370624 | 370625 | 370628 | 370629 | 370631 | 370632 | 370825 | 370826 | 371000 | 371024 | 371032