Attachment 370588 Details for Bug 198231 – Patch

[patch] Patch

bug-198231-20190524140321.patch (text/plain), 3.40 KB, created by Per Arne Vollan on 2019-05-24 14:03:22 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Per Arne Vollan

Created: 2019-05-24 14:03:22 PDT

Size: 3.40 KB

patch

obsolete

>Index: Source/WebKit/ChangeLog
>===================================================================
>--- Source/WebKit/ChangeLog	(revision 245751)
>+++ Source/WebKit/ChangeLog	(working copy)
>@@ -1,3 +1,19 @@
>+2019-05-24  Per Arne Vollan  <pvollan@apple.com>
>+
>+        Remove unused member in WebsiteDataRecord
>+        https://bugs.webkit.org/show_bug.cgi?id=198231
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        The data member 'originsWithCredentials' in WebsiteDataRecord is no longer needed since origins
>+        with credentials are now stored in the 'origins' member.
>+
>+        * UIProcess/WebsiteData/WebsiteDataRecord.cpp:
>+        (WebKit::WebsiteDataRecord::addOriginWithCredential): Deleted.
>+        * UIProcess/WebsiteData/WebsiteDataRecord.h:
>+        * UIProcess/WebsiteData/WebsiteDataStore.cpp:
>+        (WebKit::WebsiteDataStore::fetchDataAndApply):
>+
> 2019-05-24  Youenn Fablet  <youenn@apple.com>
> 
>         Update messages_unittest.py after r245715
>Index: Source/WebKit/UIProcess/WebsiteData/WebsiteDataRecord.cpp
>===================================================================
>--- Source/WebKit/UIProcess/WebsiteData/WebsiteDataRecord.cpp	(revision 245751)
>+++ Source/WebKit/UIProcess/WebsiteData/WebsiteDataRecord.cpp	(working copy)
>@@ -153,10 +153,4 @@ String WebsiteDataRecord::topPrivatelyCo
>     return emptyString();
> }
> 
>-void WebsiteDataRecord::addOriginWithCredential(const String& origin)
>-{
>-    types.add(WebsiteDataType::Credentials);
>-    originsWithCredentials.add(origin);
>-}
>-
> }
>Index: Source/WebKit/UIProcess/WebsiteData/WebsiteDataRecord.h
>===================================================================
>--- Source/WebKit/UIProcess/WebsiteData/WebsiteDataRecord.h	(revision 245751)
>+++ Source/WebKit/UIProcess/WebsiteData/WebsiteDataRecord.h	(working copy)
>@@ -53,7 +53,6 @@ struct WebsiteDataRecord {
> #if ENABLE(NETSCAPE_PLUGIN_API)
>     void addPluginDataHostName(const String& hostName);
> #endif
>-    void addOriginWithCredential(const String&);
>     void addHSTSCacheHostname(const String& hostName);
> 
>     String displayName;
>@@ -70,7 +69,6 @@ struct WebsiteDataRecord {
> #if ENABLE(NETSCAPE_PLUGIN_API)
>     HashSet<String> pluginDataHostNames;
> #endif
>-    HashSet<String> originsWithCredentials;
>     HashSet<String> HSTSCacheHostNames;
> 
>     bool matches(const WebCore::RegistrableDomain&) const;
>Index: Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp
>===================================================================
>--- Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp	(revision 245751)
>+++ Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp	(working copy)
>@@ -319,17 +319,6 @@ void WebsiteDataStore::fetchDataAndApply
>             }
> #endif
> 
>-            for (auto& origin : websiteData.originsWithCredentials) {
>-                auto displayName = WebsiteDataRecord::displayNameForOrigin(WebCore::SecurityOriginData::fromURL(URL(URL(), origin)));
>-                ASSERT(!displayName.isEmpty());
>-
>-                auto& record = m_websiteDataRecords.add(displayName, WebsiteDataRecord { }).iterator->value;
>-                if (!record.displayName)
>-                    record.displayName = WTFMove(displayName);
>-
>-                record.addOriginWithCredential(origin);
>-            }
>-
>             for (auto& hostName : websiteData.hostNamesWithHSTSCache) {
>                 auto displayName = WebsiteDataRecord::displayNameForHostName(hostName);
>                 if (!displayName)

Actions: View | Formatted Diff | Diff

Attachments on bug 198231: 370588