Attachment 370570 Details for Bug 198218 – Patch

[patch] Patch

bug-198218-20190524083639.patch (text/plain), 1.20 KB, created by Aakash Jain on 2019-05-24 05:36:40 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Aakash Jain

Created: 2019-05-24 05:36:40 PDT

Size: 1.20 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 245745)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,12 @@
>+2019-05-24  Aakash Jain  <aakash_jain@apple.com>
>+
>+        [ews-build] Do not display unnecessary steps in the Buildbot build page UI
>+        https://bugs.webkit.org/show_bug.cgi?id=198218
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * BuildSlaveSupport/ews-build/steps.py:
>+
> 2019-05-24  Yusuke Suzuki  <ysuzuki@apple.com>
> 
>         Make display-profiler-output work with newer HighLine
>Index: Tools/BuildSlaveSupport/ews-build/steps.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-build/steps.py	(revision 245745)
>+++ Tools/BuildSlaveSupport/ews-build/steps.py	(working copy)
>@@ -139,6 +139,9 @@ class ApplyPatch(shell.ShellCommand, Com
>         d = self.downloadFileContentToWorker('.buildbot-diff', patch)
>         d.addCallback(lambda res: shell.ShellCommand.start(self))
> 
>+    def hideStepIf(self, results, step):
>+        return results == SUCCESS
>+
>     def getResultSummary(self):
>         if self.results != SUCCESS:
>             return {u'step': u'Patch does not apply'}

Actions: View | Formatted Diff | Diff

Attachments on bug 198218: 370570 | 370574 | 371315 | 371329