Attachment 370523 Details for Bug 198196 – patch

[patch] patch

c-backup.diff (text/plain), 1.79 KB, created by Saam Barati on 2019-05-23 15:00:54 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Saam Barati

Created: 2019-05-23 15:00:54 PDT

Size: 1.79 KB

patch

obsolete

>Index: Source/WebCore/ChangeLog
>===================================================================
>--- Source/WebCore/ChangeLog	(revision 245719)
>+++ Source/WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,19 @@
>+2019-05-23  Saam barati  <sbarati@apple.com>
>+
>+        [WHLSL] Don't wrap anonymous variables in parens in the AST dumper
>+        https://bugs.webkit.org/show_bug.cgi?id=198196
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This makes the dump of 'foo.bar.x = 42' go from
>+        ($(0x7f86d9d94440) = &foo, $(0x7f86d9d944e0) = operator.bar(*$(0x7f86d9d94440)), $(0x7f86d9d944e0) = operator.x=($(0x7f86d9d944e0), 42), *$(0x7f86d9d94440) = operator.bar=(*$(0x7f86d9d94440), $(0x7f86d9d944e0)));
>+        
>+        to:
>+        ($0x7f86d9d94440 = &foo, $0x7f86d9d944e0 = operator.bar(*$0x7f86d9d94440), $0x7f86d9d944e0 = operator.x=($0x7f86d9d944e0, 42), *$0x7f86d9d94440 = operator.bar=(*$0x7f86d9d94440, $0x7f86d9d944e0));
>+
>+        * Modules/webgpu/WHLSL/WHLSLASTDumper.cpp:
>+        (WebCore::WHLSL::ASTDumper::visit):
>+
> 2019-05-22  Stephanie Lewis  <slewis@apple.com>
> 
>         release builds of webkit cannot be used to generate a dyld shared cache
>Index: Source/WebCore/Modules/webgpu/WHLSL/WHLSLASTDumper.cpp
>===================================================================
>--- Source/WebCore/Modules/webgpu/WHLSL/WHLSLASTDumper.cpp	(revision 245719)
>+++ Source/WebCore/Modules/webgpu/WHLSL/WHLSLASTDumper.cpp	(working copy)
>@@ -636,7 +636,7 @@ void ASTDumper::visit(AST::TernaryExpres
> void ASTDumper::visit(AST::VariableReference& variableReference)
> {
>     if (variableReference.name().isEmpty())
>-        m_out.print("$(", RawPointer(variableReference.variable()), ")");
>+        m_out.print("$", RawPointer(variableReference.variable()));
>     else
>         m_out.print(variableReference.name());
> }

Actions: View | Formatted Diff | Diff

Attachments on bug 198196: 370523