Attachment 370517 Details for Bug 198194 – Patch

[patch] Patch

bug-198194-20190523132604.patch (text/plain), 2.51 KB, created by Matt Baker on 2019-05-23 13:26:04 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Matt Baker

Created: 2019-05-23 13:26:04 PDT

Size: 2.51 KB

patch

obsolete

>Subversion Revision: 245700
>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 8c988d602de64ccdd9e9558812bf8cdc611e46f0..a1f25f2e0d65d1cfbece36a1c3fd99f884e03e7c 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-05-23  Matt Baker  <mattbaker@apple.com>
>+
>+        Web Inspector: Remove unused CSS class "offset-sections"
>+        https://bugs.webkit.org/show_bug.cgi?id=198194
>+        <rdar://problem/51080111>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/DebuggerSidebarPanel.js:
>+        * UserInterface/Views/StyleDetailsPanel.js:
>+        (WI.StyleDetailsPanel):
>+
> 2019-05-23  Devin Rousso  <drousso@apple.com>
> 
>         Web Inspector: clicking a source link should never open the Network tab
>diff --git a/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js b/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js
>index 696ffc09a70def28ccc7069f3b6d2f512d3afb74..8dc21756503bd603f8e71f9992bbb49f3414167f 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js
>@@ -124,9 +124,6 @@ WI.DebuggerSidebarPanel = class DebuggerSidebarPanel extends WI.NavigationSideba
>         this._debuggerStepOutButtonItem.enabled = false;
>         this._navigationBar.addNavigationItem(this._debuggerStepOutButtonItem);
> 
>-        // Add this offset-sections class name so the sticky headers don't overlap the navigation bar.
>-        this.element.classList.add(WI.DebuggerSidebarPanel.OffsetSectionsStyleClassName);
>-
>         function showResourcesWithIssuesOnlyFilterFunction(treeElement)
>         {
>             // Issues are only shown in the scripts tree outline.
>diff --git a/Source/WebInspectorUI/UserInterface/Views/StyleDetailsPanel.js b/Source/WebInspectorUI/UserInterface/Views/StyleDetailsPanel.js
>index 055d9cf844e4b4d470e71870bdf81c1cfc8ca2e0..f94bde4f80e7f33b1b004dc246ea7b40b169f24b 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/StyleDetailsPanel.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/StyleDetailsPanel.js
>@@ -31,8 +31,7 @@ WI.StyleDetailsPanel = class StyleDetailsPanel extends WI.View
> 
>         this._delegate = delegate || null;
> 
>-        // Add this offset-sections class name so the sticky headers don't overlap the navigation bar.
>-        this.element.classList.add(className, "offset-sections");
>+        this.element.classList.add(className);
> 
>         this._navigationInfo = {identifier, label};
>

Actions: View | Formatted Diff | Diff

Attachments on bug 198194: 370517