Attachment 370437 Details for Bug 198137 – Patch

[patch] Patch

bug-198137-20190522131131.patch (text/plain), 2.03 KB, created by Brent Fulgham on 2019-05-22 13:11:31 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Brent Fulgham

Created: 2019-05-22 13:11:31 PDT

Size: 2.03 KB

patch

obsolete

>Subversion Revision: 245639
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 910fa326e51fbdf4e4e15ac1bef38a5bc12f6b18..5843a9e2e7989b74edb94f5aa1a5287a03bbbcc2 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-05-22  Daniel Bates  <dabates@apple.com>
>+
>+        WebKit does not generate an ESC key event for CMD+.
>+        https://bugs.webkit.org/show_bug.cgi?id=198137
>+        <rdar://problem/51038641>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This patch maps the Command + '.' keystroke to the 'Escape'. This also requires a change to UIKit to properly pass
>+        the key state to WebKit (see <rdar://problem/46431552>).
>+
>+        * platform/ios/WebEvent.mm:
>+        (-[WebEvent initWithKeyEventType:timeStamp:characters:charactersIgnoringModifiers:modifiers:isRepeating:withFlags:withInputManagerHint:keyCode:isTabKey:]):
>+
> 2019-05-22  Antoine Quint  <graouts@apple.com>
> 
>         [iOS] Compatibility mouse events aren't prevented by calling preventDefault() on pointerdown
>diff --git a/Source/WebCore/platform/ios/WebEvent.mm b/Source/WebCore/platform/ios/WebEvent.mm
>index f532a841df419ec80c980aaefe697bcdb7b1b733..137cc447495cb0b4d287c5f465bdb310d87a516d 100644
>--- a/Source/WebCore/platform/ios/WebEvent.mm
>+++ b/Source/WebCore/platform/ios/WebEvent.mm
>@@ -193,6 +193,11 @@ - (WebEvent *)initWithKeyEventType:(WebEventType)type
>     }
> 
>     if (!(_keyboardFlags & WebEventKeyboardInputModifierFlagsChanged)) {
>+        // Map Command + . to Escape since Apple Smart Keyboards lack an Escape key.
>+        if ([charactersIgnoringModifiers isEqualToString:@"."] && (modifiers & WebEventFlagMaskCommandKey)) {
>+            keyCode = kHIDUsage_KeyboardEscape;
>+            _modifierFlags &= ~WebEventFlagMaskCommandKey;
>+        }
>         _characters = [normalizedStringWithAppKitCompatibilityMapping(characters, keyCode) retain];
>         _charactersIgnoringModifiers = [normalizedStringWithAppKitCompatibilityMapping(charactersIgnoringModifiers, keyCode) retain];
>         _tabKey = tabKey;

Actions: View | Formatted Diff | Diff

Attachments on bug 198137: 370437