Attachment 370428 Details for Bug 198033 – Patch

[patch] Patch

bug-198033-20190522113106.patch (text/plain), 2.00 KB, created by Zhifei Fang on 2019-05-22 11:31:07 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Zhifei Fang

Created: 2019-05-22 11:31:07 PDT

Size: 2.00 KB

patch

obsolete

>Index: Source/WebInspectorUI/ChangeLog
>===================================================================
>--- Source/WebInspectorUI/ChangeLog	(revision 245511)
>+++ Source/WebInspectorUI/ChangeLog	(working copy)
>@@ -1,3 +1,14 @@
>+2019-05-20  Zhifei Fang  <zhifei_fang@apple.com>
>+
>+        Correct the error object link color in dark mode.
>+        https://bugs.webkit.org/show_bug.cgi?id=198033
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/ErrorObjectView.css:
>+        (@media (prefers-dark-interface)):
>+        (.error-object-link-container):
>+
> 2019-05-19  Nikita Vasilyev  <nvasilyev@apple.com>
> 
>         Web Inspector: Decrease spacing before and after tooltip paragraphs
>Index: Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.css
>===================================================================
>--- Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.css	(revision 245511)
>+++ Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.css	(working copy)
>@@ -320,4 +320,13 @@ body[dir=rtl] .console-message.expandabl
>     .console-message .repeat-count {
>         background-color: hsl(218, 70%, 48%);
>     }
>+
>+    .console-message .go-to-link {
>+        color: var(--text-color-secondary);
>+    }
>+
>+    .console-message .go-to-link:hover,
>+    .console-message .go-to-link:focus {
>+        color: var(--selected-secondary-text-color-active);
>+    }
> }
>Index: Source/WebInspectorUI/UserInterface/Views/ErrorObjectView.css
>===================================================================
>--- Source/WebInspectorUI/UserInterface/Views/ErrorObjectView.css	(revision 245511)
>+++ Source/WebInspectorUI/UserInterface/Views/ErrorObjectView.css	(working copy)
>@@ -53,6 +53,12 @@ body[dir=rtl] .error-object > .formatted
>     color: hsla(0, 0%, 0%, 0.2);
> }
> 
>+@media (prefers-dark-interface) {
>+    .error-object-link-container {
>+        color: var(--text-color-secondary);
>+    }
>+}
>+
> .error-object.expanded > .formatted-error > .error-object-link-container {
>     display: none;
> }

Actions: View | Formatted Diff | Diff

Attachments on bug 198033: 370241 | 370242 | 370243 | 370244 | 370245 | 370265 | 370428