Attachment 370356 Details for Bug 198094 – Patch

[patch] Patch

bug-198094-20190521163935.patch (text/plain), 1.70 KB, created by Jer Noble on 2019-05-21 16:39:36 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Jer Noble

Created: 2019-05-21 16:39:36 PDT

Size: 1.70 KB

patch

obsolete

>Subversion Revision: 245594
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 97963e5203f77d755c5eb03c09ee5b985cc85ea7..c473861e8b811d0e45381a482b5968b8a6554c16 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-05-21  Jer Noble  <jer.noble@apple.com>
>+
>+        Media controls don't show in WK2 video fullscreen sometimes
>+        https://bugs.webkit.org/show_bug.cgi?id=198094
>+        <rdar://problem/50970661>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Ensure that the WebAVPlayerLayer never allows hit testing, as this keeps touches from reaching
>+        AVKit's controls.
>+
>+        * platform/ios/VideoFullscreenInterfaceAVKit.mm:
>+        (-[WebAVPlayerLayer init]):
>+
> 2019-05-21  Jer Noble  <jer.noble@apple.com>
> 
>         WeakPtr breaks vtables when upcasting to base classes
>diff --git a/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm b/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm
>index 41e4017bfd5a4653dc44bf76b97a46f692a65e94..bfc084d2df28d4f36d2a5f8f4e3773922571fa3a 100644
>--- a/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm
>+++ b/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm
>@@ -44,6 +44,7 @@
> #import <objc/message.h>
> #import <objc/runtime.h>
> #import <pal/spi/cocoa/AVKitSPI.h>
>+#import <pal/spi/cocoa/QuartzCoreSPI.h>
> #import <pal/spi/ios/UIKitSPI.h>
> #import <wtf/RetainPtr.h>
> #import <wtf/text/CString.h>
>@@ -203,7 +204,8 @@ - (instancetype)init
> {
>     self = [super init];
>     if (self) {
>-        [self setMasksToBounds:YES];
>+        self.masksToBounds = YES;
>+        self.allowsHitTesting = NO;
>         _videoGravity = AVLayerVideoGravityResizeAspect;
>     }
>     return self;

Actions: View | Formatted Diff | Diff

Attachments on bug 198094: 370356