Attachment 370333 Details for Bug 197898 – Patch

[patch] Patch

bug-197898-20190521212058.patch (text/plain), 1.64 KB, created by Tadeu Zagallo on 2019-05-21 12:21:00 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Tadeu Zagallo

Created: 2019-05-21 12:21:00 PDT

Size: 1.64 KB

patch

obsolete

>Subversion Revision: 245588
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index ae0f6eb29125bb121054b2d375ca9f0cbf61f026..79097a6d5410b414ddab98c6437b8ad6e458df72 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,14 @@
>+2019-05-21  Tadeu Zagallo  <tzagallo@apple.com>
>+
>+        Fix production build after r245564
>+        https://bugs.webkit.org/show_bug.cgi?id=197898
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        The production configuration should not set CODE_SIGN_IDENTITY.
>+
>+        * Configurations/ToolExecutable.xcconfig:
>+
> 2019-05-21  Keith Miller  <keith_miller@apple.com>
> 
>         Unreviewed build fix add UNUSED_PARAM.
>diff --git a/Source/JavaScriptCore/Configurations/ToolExecutable.xcconfig b/Source/JavaScriptCore/Configurations/ToolExecutable.xcconfig
>index f228646296c7b6292f68caf4092d49c5a3ab9fd1..263942d2253154a089f2c8eb77d2163002b7d21c 100644
>--- a/Source/JavaScriptCore/Configurations/ToolExecutable.xcconfig
>+++ b/Source/JavaScriptCore/Configurations/ToolExecutable.xcconfig
>@@ -33,7 +33,11 @@ USE_INTERNAL_SDK_Production = YES;
> USE_INTERNAL_SDK_Debug = $(HAVE_INTERNAL_SDK);
> USE_INTERNAL_SDK_Release = $(HAVE_INTERNAL_SDK);
> 
>-CODE_SIGN_IDENTITY[sdk=macosx*] = $(CODE_SIGN_IDENTITY_$(USE_INTERNAL_SDK))
>+CODE_SIGN_IDENTITY[sdk=macosx*] = $(CODE_SIGN_IDENTITY_$(CONFIGURATION));
>+
>+CODE_SIGN_IDENTITY_Production = $(CODE_SIGN_IDENTITY_NO);
>+CODE_SIGN_IDENTITY_Debug = $(CODE_SIGN_IDENTITY_$(USE_INTERNAL_SDK));
>+CODE_SIGN_IDENTITY_Release = $(CODE_SIGN_IDENTITY_$(USE_INTERNAL_SDK));
> 
> CODE_SIGN_IDENTITY_ = $(CODE_SIGN_IDENTITY_NO);
> CODE_SIGN_IDENTITY_NO = -;

Actions: View | Formatted Diff | Diff

Attachments on bug 197898: 369910 | 369958 | 370158 | 370220 | 370300 | 370333