Attachment 370306 Details for Bug 198069 – patch

[patch] patch

bug-198069-20190521115438.patch (text/plain), 1.31 KB, created by Pablo Saavedra on 2019-05-21 02:54:40 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Pablo Saavedra

Created: 2019-05-21 02:54:40 PDT

Size: 1.31 KB

patch

obsolete

>Subversion Revision: 245564
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 12ec5a7bb73b90681f4ad1eb0b7774badc06fc59..45d4e21933bf62fd7a9b018fa602168a8dc478ac 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,12 @@
>+2019-05-21  Pablo Saavedra  <psaavedra@igalia.com>
>+
>+        Undefined reference platformCloseFrontendPageAndWindow() linking against libWPEWebKit-1.0.so after r245536
>+        https://bugs.webkit.org/show_bug.cgi?id=198069
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UIProcess/RemoteWebInspectorProxy.cpp:
>+
> 2019-05-20  Alex Christensen  <achristensen@webkit.org>
> 
>         Revert r245501
>diff --git a/Source/WebKit/UIProcess/RemoteWebInspectorProxy.cpp b/Source/WebKit/UIProcess/RemoteWebInspectorProxy.cpp
>index 954098b0f5fb20c497dd469832f09fcf00add875..6679d45bd9969204afcf5bb2f4e9a48e6164389d 100644
>--- a/Source/WebKit/UIProcess/RemoteWebInspectorProxy.cpp
>+++ b/Source/WebKit/UIProcess/RemoteWebInspectorProxy.cpp
>@@ -170,7 +170,7 @@ void RemoteWebInspectorProxy::closeFrontendPageAndWindow()
>     platformCloseFrontendPageAndWindow();
> }
> 
>-#if !ENABLE(REMOTE_INSPECTOR) && !PLATFORM(MAC)
>+#if (!ENABLE(REMOTE_INSPECTOR) && !PLATFORM(MAC)) || PLATFORM(WPE)
> WebPageProxy* RemoteWebInspectorProxy::platformCreateFrontendPageAndWindow()
> {
>     notImplemented();

Actions: View | Formatted Diff | Diff

Attachments on bug 198069: 370306