Attachment 370298 Details for Bug 198068 – Patch

[patch] Patch

bug-198068-20190520205233.patch (text/plain), 1.84 KB, created by Jiewen Tan on 2019-05-20 20:52:34 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Jiewen Tan

Created: 2019-05-20 20:52:34 PDT

Size: 1.84 KB

patch

obsolete

>Subversion Revision: 245539
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index efeb55cb9dfdb9285f49803219f25e319ffd9e6f..616e4047f1e12f685909c04d842b7bd287e965d5 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,14 @@
>+2019-05-20  Jiewen Tan  <jiewen_tan@apple.com>
>+
>+        [WebAuthN] Make WebAuthN default on only on macOS
>+        https://bugs.webkit.org/show_bug.cgi?id=198068
>+        <rdar://problem/50971874>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Shared/WebPreferences.yaml:
>+        * Shared/WebPreferencesDefaultValues.h:
>+
> 2019-05-20  Ross Kirsling  <ross.kirsling@sony.com>
> 
>         [WinCairo] Implement Remote Web Inspector Client.
>diff --git a/Source/WebKit/Shared/WebPreferences.yaml b/Source/WebKit/Shared/WebPreferences.yaml
>index b3dad07c2390fd84ab6c88d63f48a641674de7f4..e59efb801cb31ae07dee12253c15715489d8df56 100644
>--- a/Source/WebKit/Shared/WebPreferences.yaml
>+++ b/Source/WebKit/Shared/WebPreferences.yaml
>@@ -749,7 +749,7 @@ InputEventsEnabled:
> 
> WebAuthenticationEnabled:
>   type: bool
>-  defaultValue: true
>+  defaultValue: DEFAULT_WEB_AUTHENTICATION_ENABLED
>   humanReadableName: "Web Authentication"
>   humanReadableDescription: "Enable Web Authentication support"
>   webcoreBinding: RuntimeEnabledFeatures
>diff --git a/Source/WebKit/Shared/WebPreferencesDefaultValues.h b/Source/WebKit/Shared/WebPreferencesDefaultValues.h
>index 3643966d5af8bca9f9eeed3e77b1eae0cffb9f72..48e2eba43535443d1efe763d1fbd35015b3b5b0f 100644
>--- a/Source/WebKit/Shared/WebPreferencesDefaultValues.h
>+++ b/Source/WebKit/Shared/WebPreferencesDefaultValues.h
>@@ -272,3 +272,9 @@ bool defaultCustomPasteboardDataEnabled();
> #else
> #define DEFAULT_APPLE_PAY_ENABLED false
> #endif
>+
>+#if PLATFORM(MAC)
>+#define DEFAULT_WEB_AUTHENTICATION_ENABLED true
>+#else
>+#define DEFAULT_WEB_AUTHENTICATION_ENABLED false
>+#endif

Actions: View | Formatted Diff | Diff

Attachments on bug 198068: 370298 | 370309