Attachment 370275 Details for Bug 198058 – Patch

[patch] Patch

bug-198058-20190520190814.patch (text/plain), 1.91 KB, created by Aakash Jain on 2019-05-20 16:08:15 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Aakash Jain

Created: 2019-05-20 16:08:15 PDT

Size: 1.91 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 245539)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,12 @@
>+2019-05-20  Aakash Jain  <aakash_jain@apple.com>
>+
>+        Windows 10 test results missing on flakiness dashboard
>+        https://bugs.webkit.org/show_bug.cgi?id=198058
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * TestResultServer/static-dashboards/flakiness_dashboard.js:
>+
> 2019-05-20  Keith Rollin  <krollin@apple.com>
> 
>         generate-xcfilelists is stranding temporary files
>Index: Tools/TestResultServer/static-dashboards/flakiness_dashboard.js
>===================================================================
>--- Tools/TestResultServer/static-dashboards/flakiness_dashboard.js	(revision 245539)
>+++ Tools/TestResultServer/static-dashboards/flakiness_dashboard.js	(working copy)
>@@ -67,7 +67,8 @@ var PLATFORMS = {
>                 expectationsDirectory: 'win',
>                 subPlatforms: {
>                     'XP': { fallbackPlatforms: ['APPLE_WIN'] },
>-                    'WIN7': { fallbackPlatforms: ['APPLE_WIN'] }
>+                    'WIN7': { fallbackPlatforms: ['APPLE_WIN'] },
>+                    'WIN10': { fallbackPlatforms: ['APPLE_WIN'] }
>                 }
>             }
>         }
>@@ -343,6 +344,8 @@ function determineWKPlatform(builderName
> 
> function determineBuilderPlatform(builderNameUpperCase)
> {
>+    if (string.contains(builderNameUpperCase, 'WIN 10'))
>+        return 'APPLE_WIN_WIN10';
>     if (string.contains(builderNameUpperCase, 'WIN 7'))
>         return 'APPLE_WIN_WIN7';
>     if (string.contains(builderNameUpperCase, 'WIN XP'))
>@@ -710,6 +713,7 @@ function getParsedExpectations(data)
>             'HighSierra': 'HIGHSIERRA',
>             'Mojave': 'MOJAVE',
>             'Win7': 'WIN7',
>+            'Win10': 'WIN10',
>             'XP': 'XP',
>             'Vista': 'VISTA',
>             'Android': 'ANDROID',

Flags:

ap: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 198058: 370275