WebKit Bugzilla
Attachment 370272 Details for
Bug 198052
: Provide an explicit UIModalPresentation style when creating an AVPlayerViewController for fullscreen.
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-198052-20190520144543.patch (text/plain), 1.65 KB, created by
Jer Noble
on 2019-05-20 14:45:43 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Jer Noble
Created:
2019-05-20 14:45:43 PDT
Size:
1.65 KB
patch
obsolete
>Subversion Revision: 245248 >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index 3baf4643f151d39e9e9d997f3323b9b43c9dce57..5a861a3181522128005fdb154bbd30ba802e9eb9 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,15 @@ >+2019-05-20 Jer Noble <jer.noble@apple.com> >+ >+ Provide an explicit UIModalPresentation style when creating an AVPlayerViewController for fullscreen. >+ https://bugs.webkit.org/show_bug.cgi?id=198052 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Make sure AVPlayerViewController has an "overFullScreen" modal style. >+ >+ * platform/ios/VideoFullscreenInterfaceAVKit.mm: >+ (-[WebAVPlayerViewController initWithFullscreenInterface:]): >+ > 2019-05-01 Jer Noble <jer.noble@apple.com> > > Hide MediaCapabilities.encodingInfo() when the platform does not support it. >diff --git a/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm b/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm >index f11f9d83f18eea2db9d915938e61bd36ad072822..41e4017bfd5a4653dc44bf76b97a46f692a65e94 100644 >--- a/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm >+++ b/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm >@@ -551,6 +551,7 @@ - (instancetype)initWithFullscreenInterface:(VideoFullscreenInterfaceAVKit *)int > > _fullscreenInterface = interface; > _avPlayerViewController = adoptNS([allocAVPlayerViewControllerInstance() initWithPlayerLayerView:interface->playerLayerView()]); >+ _avPlayerViewController.get().modalPresentationStyle = UIModalPresentationOverFullScreen; > #if PLATFORM(WATCHOS) > _avPlayerViewController.get().delegate = self; > #endif
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 198052
: 370272