Attachment 370150 Details for Bug 198000 – Patch

[patch] Patch

bug-198000-20190517171536.patch (text/plain), 1.26 KB, created by Aakash Jain on 2019-05-17 14:15:37 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Aakash Jain

Created: 2019-05-17 14:15:37 PDT

Size: 1.26 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 245476)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,13 @@
>+2019-05-17  Aakash Jain  <aakash_jain@apple.com>
>+
>+        [ews-app] Status bubble should not turn orange when any build step has warnings
>+        https://bugs.webkit.org/show_bug.cgi?id=198000
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
>+        (StatusBubble._does_build_contains_any_failed_step):
>+
> 2019-05-17  Keith Rollin  <krollin@apple.com>
> 
>         Unreviewed build fix.
>Index: Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py	(revision 245476)
>+++ Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py	(working copy)
>@@ -155,7 +155,7 @@ class StatusBubble(View):
> 
>     def _does_build_contains_any_failed_step(self, build):
>         for step in build.step_set.all():
>-            if step.result and step.result != Buildbot.SUCCESS:
>+            if step.result and step.result != Buildbot.SUCCESS and step.result != Buildbot.WARNINGS:
>                 return True
>         return False
>

Actions: View | Formatted Diff | Diff

Attachments on bug 198000: 370150