Attachment 370073 Details for Bug 197764 – Patch

[patch] Patch

bug-197764-20190516145409.patch (text/plain), 10.19 KB, created by gr3g on 2019-05-16 14:54:09 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: gr3g

Created: 2019-05-16 14:54:09 PDT

Size: 10.19 KB

patch

obsolete

>Subversion Revision: 245396
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 0bd242bbc38e168b33befd0feb0e76647d56f6b9..b3e230e57e83108681adc58014faa72eb7181543 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,25 @@
>+2019-05-16  Greg Doolittle  <gr3g@apple.com>
>+
>+        AX: Unship some ARIA string reflectors that are to-be-replaced by element reflection
>+        https://bugs.webkit.org/show_bug.cgi?id=197764
>+        <rdar://problem/50649689>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Specifically these:
>+        - ariaActiveDescendant
>+        - ariaControls
>+        - ariaDescribedBy
>+        - ariaDetails
>+        - ariaErrorMessage
>+        - ariaFlowTo
>+        - ariaLabelledBy
>+        - ariaOwns
>+
>+        Test: LayoutTests/accessibility/ARIA-reflections.html (updated)
>+
>+        * accessibility/AriaAttributes.idl:
>+
> 2019-05-16  Ali Juma  <ajuma@chromium.org>
> 
>         [IntersectionObserver] Regression: No initial observation when nothing else triggers rendering
>diff --git a/Source/WebCore/accessibility/AriaAttributes.idl b/Source/WebCore/accessibility/AriaAttributes.idl
>index 8422b539febdf0c67e4bb452bc6679af95a20fcb..d2874a7c516a8f51713360fef2dbbda8c1c5f0ee 100644
>--- a/Source/WebCore/accessibility/AriaAttributes.idl
>+++ b/Source/WebCore/accessibility/AriaAttributes.idl
>@@ -27,7 +27,6 @@
>     EnabledAtRuntime=AriaReflection,
>     NoInterfaceObject,
> ] interface AriaAttributes {
>-    [Reflect=aria_activedescendant] attribute DOMString? ariaActiveDescendant;
>     [Reflect=aria_atomic]           attribute DOMString? ariaAtomic;
>     [Reflect=aria_autocomplete]     attribute DOMString? ariaAutoComplete;
>     [Reflect=aria_busy]             attribute DOMString? ariaBusy;
>@@ -35,27 +34,20 @@
>     [Reflect=aria_colcount]         attribute DOMString? ariaColCount;
>     [Reflect=aria_colindex]         attribute DOMString? ariaColIndex;
>     [Reflect=aria_colspan]          attribute DOMString? ariaColSpan;
>-    [Reflect=aria_controls]         attribute DOMString? ariaControls;
>     [Reflect=aria_current]          attribute DOMString? ariaCurrent;
>-    [Reflect=aria_describedby]      attribute DOMString? ariaDescribedBy;
>-    [Reflect=aria_details]          attribute DOMString? ariaDetails;
>     [Reflect=aria_disabled]         attribute DOMString? ariaDisabled;
>-    [Reflect=aria_errormessage]     attribute DOMString? ariaErrorMessage;
>     [Reflect=aria_expanded]         attribute DOMString? ariaExpanded;
>-    [Reflect=aria_flowto]           attribute DOMString? ariaFlowTo;
>     [Reflect=aria_haspopup]         attribute DOMString? ariaHasPopup;
>     [Reflect=aria_hidden]           attribute DOMString? ariaHidden;
>     [Reflect=aria_invalid]          attribute DOMString? ariaInvalid;
>     [Reflect=aria_keyshortcuts]     attribute DOMString? ariaKeyShortcuts;
>     [Reflect=aria_label]            attribute DOMString? ariaLabel;
>-    [Reflect=aria_labelledby]       attribute DOMString? ariaLabelledBy;
>     [Reflect=aria_level]            attribute DOMString? ariaLevel;
>     [Reflect=aria_live]             attribute DOMString? ariaLive;
>     [Reflect=aria_modal]            attribute DOMString? ariaModal;
>     [Reflect=aria_multiline]        attribute DOMString? ariaMultiLine;
>     [Reflect=aria_multiselectable]  attribute DOMString? ariaMultiSelectable;
>     [Reflect=aria_orientation]      attribute DOMString? ariaOrientation;
>-    [Reflect=aria_owns]             attribute DOMString? ariaOwns;
>     [Reflect=aria_placeholder]      attribute DOMString? ariaPlaceholder;
>     [Reflect=aria_posinset]         attribute DOMString? ariaPosInSet;
>     [Reflect=aria_pressed]          attribute DOMString? ariaPressed;
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index a8108e792168363618850905caece7de5c7356e7..4b69139c938fb10f245d6eb2463e3d831ab0eb5a 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,24 @@
>+2019-05-16  Greg Doolittle  <gr3g@apple.com>
>+
>+        AX: Unship some ARIA string reflectors that are to-be-replaced by element reflection
>+        https://bugs.webkit.org/show_bug.cgi?id=197764
>+        <rdar://problem/50649689>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Specifically these:
>+        - ariaActiveDescendant
>+        - ariaControls
>+        - ariaDescribedBy
>+        - ariaDetails
>+        - ariaErrorMessage
>+        - ariaFlowTo
>+        - ariaLabelledBy
>+        - ariaOwns
>+
>+        * accessibility/ARIA-reflection-expected.txt: Updated.
>+        * accessibility/ARIA-reflection.html: Updated.
>+
> 2019-05-16  Ali Juma  <ajuma@chromium.org>
> 
>         [IntersectionObserver] Regression: No initial observation when nothing else triggers rendering
>diff --git a/LayoutTests/accessibility/ARIA-reflection-expected.txt b/LayoutTests/accessibility/ARIA-reflection-expected.txt
>index cbf356bdba33f91b5f8200f775a9894d32292e04..9504b69bcbacd241b95854302ef5474e352a498e 100644
>--- a/LayoutTests/accessibility/ARIA-reflection-expected.txt
>+++ b/LayoutTests/accessibility/ARIA-reflection-expected.txt
>@@ -12,14 +12,6 @@ PASS element.getAttribute(currentAttribute) is data
> element.setAttribute("role", otherData);
> PASS element[currentProperty] is otherData
> 
>-Test ariaActiveDescendant < - > aria-activedescendant
>-PASS element[currentProperty] is null
>-PASS element.getAttribute(currentAttribute) is null
>-element["ariaActiveDescendant"] = data;
>-PASS element.getAttribute(currentAttribute) is data
>-element.setAttribute("aria-activedescendant", otherData);
>-PASS element[currentProperty] is otherData
>-
> Test ariaAtomic < - > aria-atomic
> PASS element[currentProperty] is null
> PASS element.getAttribute(currentAttribute) is null
>@@ -76,14 +68,6 @@ PASS element.getAttribute(currentAttribute) is data
> element.setAttribute("aria-colspan", otherData);
> PASS element[currentProperty] is otherData
> 
>-Test ariaControls < - > aria-controls
>-PASS element[currentProperty] is null
>-PASS element.getAttribute(currentAttribute) is null
>-element["ariaControls"] = data;
>-PASS element.getAttribute(currentAttribute) is data
>-element.setAttribute("aria-controls", otherData);
>-PASS element[currentProperty] is otherData
>-
> Test ariaCurrent < - > aria-current
> PASS element[currentProperty] is null
> PASS element.getAttribute(currentAttribute) is null
>@@ -92,22 +76,6 @@ PASS element.getAttribute(currentAttribute) is data
> element.setAttribute("aria-current", otherData);
> PASS element[currentProperty] is otherData
> 
>-Test ariaDescribedBy < - > aria-describedby
>-PASS element[currentProperty] is null
>-PASS element.getAttribute(currentAttribute) is null
>-element["ariaDescribedBy"] = data;
>-PASS element.getAttribute(currentAttribute) is data
>-element.setAttribute("aria-describedby", otherData);
>-PASS element[currentProperty] is otherData
>-
>-Test ariaDetails < - > aria-details
>-PASS element[currentProperty] is null
>-PASS element.getAttribute(currentAttribute) is null
>-element["ariaDetails"] = data;
>-PASS element.getAttribute(currentAttribute) is data
>-element.setAttribute("aria-details", otherData);
>-PASS element[currentProperty] is otherData
>-
> Test ariaDisabled < - > aria-disabled
> PASS element[currentProperty] is null
> PASS element.getAttribute(currentAttribute) is null
>@@ -116,14 +84,6 @@ PASS element.getAttribute(currentAttribute) is data
> element.setAttribute("aria-disabled", otherData);
> PASS element[currentProperty] is otherData
> 
>-Test ariaErrorMessage < - > aria-errormessage
>-PASS element[currentProperty] is null
>-PASS element.getAttribute(currentAttribute) is null
>-element["ariaErrorMessage"] = data;
>-PASS element.getAttribute(currentAttribute) is data
>-element.setAttribute("aria-errormessage", otherData);
>-PASS element[currentProperty] is otherData
>-
> Test ariaExpanded < - > aria-expanded
> PASS element[currentProperty] is null
> PASS element.getAttribute(currentAttribute) is null
>@@ -132,14 +92,6 @@ PASS element.getAttribute(currentAttribute) is data
> element.setAttribute("aria-expanded", otherData);
> PASS element[currentProperty] is otherData
> 
>-Test ariaFlowTo < - > aria-flowto
>-PASS element[currentProperty] is null
>-PASS element.getAttribute(currentAttribute) is null
>-element["ariaFlowTo"] = data;
>-PASS element.getAttribute(currentAttribute) is data
>-element.setAttribute("aria-flowto", otherData);
>-PASS element[currentProperty] is otherData
>-
> Test ariaHasPopup < - > aria-haspopup
> PASS element[currentProperty] is null
> PASS element.getAttribute(currentAttribute) is null
>@@ -180,14 +132,6 @@ PASS element.getAttribute(currentAttribute) is data
> element.setAttribute("aria-label", otherData);
> PASS element[currentProperty] is otherData
> 
>-Test ariaLabelledBy < - > aria-labelledby
>-PASS element[currentProperty] is null
>-PASS element.getAttribute(currentAttribute) is null
>-element["ariaLabelledBy"] = data;
>-PASS element.getAttribute(currentAttribute) is data
>-element.setAttribute("aria-labelledby", otherData);
>-PASS element[currentProperty] is otherData
>-
> Test ariaLevel < - > aria-level
> PASS element[currentProperty] is null
> PASS element.getAttribute(currentAttribute) is null
>@@ -236,14 +180,6 @@ PASS element.getAttribute(currentAttribute) is data
> element.setAttribute("aria-orientation", otherData);
> PASS element[currentProperty] is otherData
> 
>-Test ariaOwns < - > aria-owns
>-PASS element[currentProperty] is null
>-PASS element.getAttribute(currentAttribute) is null
>-element["ariaOwns"] = data;
>-PASS element.getAttribute(currentAttribute) is data
>-element.setAttribute("aria-owns", otherData);
>-PASS element[currentProperty] is otherData
>-
> Test ariaPlaceholder < - > aria-placeholder
> PASS element[currentProperty] is null
> PASS element.getAttribute(currentAttribute) is null
>@@ -381,7 +317,7 @@ element.setAttribute("aria-valuetext", otherData);
> PASS element[currentProperty] is otherData
> 
> 
>-PASS count is 46
>+PASS count is 38
> PASS successfullyParsed is true
> 
> TEST COMPLETE
>diff --git a/LayoutTests/accessibility/ARIA-reflection.html b/LayoutTests/accessibility/ARIA-reflection.html
>index 0b639c15f789e3b369adf279efe0d50ab7b78f4c..323b189c4e3e401a4ffd56d4cfee464729aff918 100644
>--- a/LayoutTests/accessibility/ARIA-reflection.html
>+++ b/LayoutTests/accessibility/ARIA-reflection.html
>@@ -59,7 +59,7 @@
>         }
> 
>         debug("\n");
>-        shouldBe("count", "46");
>+        shouldBe("count", "38");
> 
>     } else {
>         testFailed("Could not load accessibility controller");

Actions: View | Formatted Diff | Diff

Attachments on bug 197764: 370073