Attachment 369903 Details for Bug 195102 – Patch

[patch] Patch

bug-195102-20190514155329.patch (text/plain), 1.92 KB, created by Chris Dumez on 2019-05-14 15:53:30 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Dumez

Created: 2019-05-14 15:53:30 PDT

Size: 1.92 KB

patch

obsolete

>Subversion Revision: 245297
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index c4f34e1046607ed1fc6e7d25d72e44b48fc293e7..03c03385e161a0861d0fb5e3fb1823f190103373 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-05-14  Chris Dumez  <cdumez@apple.com>
>+
>+        Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
>+        https://bugs.webkit.org/show_bug.cgi?id=195102
>+        <rdar://problem/48456786>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Try to wait longer for the number of processes to reach the expected number
>+        and before failing.
>+
>+        * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
>+
> 2019-05-14  Commit Queue  <commit-queue@webkit.org>
> 
>         Unreviewed, rolling out r245281.
>diff --git a/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm b/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm
>index 2e8e8e297eafba8fffb9e0344474ff736828c431..4c3ca9fde9766ebd956285af13a729e27fb54a5d 100644
>--- a/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm
>+++ b/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm
>@@ -3510,8 +3510,8 @@ TEST(ProcessSwap, NumberOfCachedProcesses)
>     TestWebKitAPI::Util::run(&done);
>     done = false;
> 
>-    int timeout = 10;
>-    while ([processPool _webProcessCount] > (maxSuspendedPageCount + 2) && timeout > 0) {
>+    int timeout = 100;
>+    while (([processPool _webProcessCount] > (maxSuspendedPageCount + 2) &&  [processPool _webProcessCountIgnoringPrewarmedAndCached] > (maxSuspendedPageCount + 1)) && timeout > 0) {
>         TestWebKitAPI::Util::sleep(0.1);
>         --timeout;
>     }
>@@ -3526,7 +3526,7 @@ TEST(ProcessSwap, NumberOfCachedProcesses)
>     }];
>     TestWebKitAPI::Util::run(&readyToContinue);
> 
>-    timeout = 10;
>+    timeout = 100;
>     while ([processPool _webProcessCount] > 1 && timeout > 0) {
>         TestWebKitAPI::Util::sleep(0.1);
>         --timeout;

Actions: View | Formatted Diff | Diff

Attachments on bug 195102: 363145 | 369903