Attachment 369893 Details for Bug 197895 – Patch

[patch] Patch

bug-197895-20190514143057.patch (text/plain), 3.46 KB, created by Alex Christensen on 2019-05-14 14:30:58 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Christensen

Created: 2019-05-14 14:30:58 PDT

Size: 3.46 KB

patch

obsolete

>Index: Source/WebKit/ChangeLog
>===================================================================
>--- Source/WebKit/ChangeLog	(revision 245250)
>+++ Source/WebKit/ChangeLog	(working copy)
>@@ -1,3 +1,14 @@
>+2019-05-14  Alex Christensen  <achristensen@webkit.org>
>+
>+        Allow NSFileCoordinator to be called from WebContent process
>+        https://bugs.webkit.org/show_bug.cgi?id=197895
>+        <rdar://problem/50107679>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * WebProcess/com.apple.WebProcess.sb.in:
>+        Expand sandbox to allow use of com.apple.FileCoordination mach service like we do on iOS.
>+
> 2019-05-13  Brent Fulgham  <bfulgham@apple.com>
> 
>         Correct the sandbox to allow loading libraries from /Library/Apple 
>Index: Source/WebKit/WebProcess/com.apple.WebProcess.sb.in
>===================================================================
>--- Source/WebKit/WebProcess/com.apple.WebProcess.sb.in	(revision 245250)
>+++ Source/WebKit/WebProcess/com.apple.WebProcess.sb.in	(working copy)
>@@ -593,6 +593,9 @@
> (allow mach-lookup
>        (global-name "com.apple.webinspector"))
> 
>+(allow mach-lookup
>+    (global-name "com.apple.FileCoordination"))
>+
> ;; Various services required by AppKit and other frameworks
> (allow mach-lookup
> #if __MAC_OS_X_VERSION_MIN_REQUIRED < 101400
>@@ -986,6 +989,9 @@
>         (syscall-number SYS_quotactl) ;; <rdar://problem/49945031>
>         (syscall-number SYS_stat64_extended) ;; <rdar://problem/50473330>
>         (syscall-number SYS_lstat64_extended)
>+        (syscall-number SYS_iopolicysys)
>+        (syscall-number SYS_workq_open)
>+        (syscall-number SYS_getgroups)
>     )
> )
> 
>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 245310)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,16 @@
>+2019-05-14  Alex Christensen  <achristensen@webkit.org>
>+
>+        Allow NSFileCoordinator to be called from WebContent process
>+        https://bugs.webkit.org/show_bug.cgi?id=197895
>+        <rdar://problem/50107679>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Add a unit test that verifies calling the block succeeds.
>+
>+        * TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLsPlugin.mm:
>+        (-[AdditionalReadAccessAllowedURLsPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
>+
> 2019-05-14  Youenn Fablet  <youenn@apple.com>
> 
>         A service worker process should app nap when all its clients app nap
>Index: Tools/TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLsPlugin.mm
>===================================================================
>--- Tools/TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLsPlugin.mm	(revision 245250)
>+++ Tools/TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLsPlugin.mm	(working copy)
>@@ -52,6 +52,13 @@ - (void)webProcessPlugIn:(WKWebProcessPl
> 
>     _interface = [_WKRemoteObjectInterface remoteObjectInterfaceWithProtocol:@protocol(AdditionalReadAccessAllowedURLsProtocol)];
>     [[browserContextController _remoteObjectRegistry] registerExportedObject:self interface:_interface.get()];
>+
>+    __block bool blockCalled = false;
>+    NSFileCoordinator *coordinator = [[NSFileCoordinator alloc] initWithFilePresenter:nil];
>+    [coordinator coordinateReadingItemAtURL:[NSURL fileURLWithPath:@"/Applications/Safari.app"] options:NSFileCoordinatorReadingWithoutChanges error:nil byAccessor:^(NSURL *newURL) {
>+        blockCalled = true;
>+    }];
>+    ASSERT(blockCalled);
> }
> 
> - (void)dealloc

Actions: View | Formatted Diff | Diff

Attachments on bug 197895: 369893