Attachment 369799 Details for Bug 197859 – Patch

[patch] Patch

bug-197859-20190513161916.patch (text/plain), 2.41 KB, created by Daniel Bates on 2019-05-13 16:19:17 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Daniel Bates

Created: 2019-05-13 16:19:17 PDT

Size: 2.41 KB

patch

obsolete

>Subversion Revision: 245179
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index ae0e2beb490d87ee6691ba2eb3872c9ac8c7983d..fcf2377f8029e5fd918a9774b0e03e5195e4af6c 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,18 @@
>+2019-05-13  Daniel Bates  <dabates@apple.com>
>+
>+        [iOS] Cannot tab or shift + tab out of address bar on google.com
>+        https://bugs.webkit.org/show_bug.cgi?id=197859
>+        <rdar://problem/46651565>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Non-editable elements can participate in tab cycling via the HTML tabindex attribute.
>+        We should allow setting the initial focus to such an element when transitioning from
>+        the chrome (e.g. address bar) to the web page.
>+
>+        * UIProcess/ios/WKContentViewInteraction.mm:
>+        (-[WKContentView _becomeFirstResponderWithSelectionMovingForward:completionHandler:]):
>+
> 2019-05-13  Daniel Bates  <dabates@apple.com>
> 
>         [iOS] Cannot scroll to beginning of document after scrolling to end of document and vice versa via key commands
>diff --git a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>index e6b11236b976015bf9607a80ab12f91abc73a105..9fff78f0559c236ab70a426aebda86dfac4aef4c 100644
>--- a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>+++ b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>@@ -3788,12 +3788,9 @@ - (void)_previousAccessoryTabForWebView:(id)sender
> 
> - (void)_becomeFirstResponderWithSelectionMovingForward:(BOOL)selectingForward completionHandler:(void (^)(BOOL didBecomeFirstResponder))completionHandler
> {
>-    auto completionHandlerCopy = Block_copy(completionHandler);
>-    RetainPtr<WKContentView> view = self;
>-    _page->setInitialFocus(selectingForward, false, WebKit::WebKeyboardEvent(), [view, completionHandlerCopy](WebKit::CallbackBase::Error) {
>-        BOOL didBecomeFirstResponder = view->_focusedElementInformation.elementType != WebKit::InputType::None && [view becomeFirstResponder];
>-        completionHandlerCopy(didBecomeFirstResponder);
>-        Block_release(completionHandlerCopy);
>+    constexpr bool isKeyboardEventValid = false;
>+    _page->setInitialFocus(selectingForward, isKeyboardEventValid, { }, [protectedSelf = retainPtr(self), completionHandler = makeBlockPtr(completionHandler)] (auto) {
>+        completionHandler([protectedSelf becomeFirstResponder]);
>     });
> }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 197859: 369799 | 369834