Attachment 369763 Details for Bug 197803 – Patch

[patch] Patch

bug-197803-20190513123929.patch (text/plain), 2.54 KB, created by youenn fablet on 2019-05-13 12:39:30 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2019-05-13 12:39:30 PDT

Size: 2.54 KB

patch

obsolete

>Subversion Revision: 245233
>diff --git a/Source/WTF/ChangeLog b/Source/WTF/ChangeLog
>index 3742b1866829cad2450ad37eb18fbef56b9b2bfc..d2eaa5a89850deea398b552426f500a64edb18a0 100644
>--- a/Source/WTF/ChangeLog
>+++ b/Source/WTF/ChangeLog
>@@ -1,3 +1,12 @@
>+2019-05-10  Youenn Fablet  <youenn@apple.com>
>+
>+        [Mac] Use realpath for dlopen_preflight
>+        https://bugs.webkit.org/show_bug.cgi?id=197803
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * wtf/cocoa/SoftLinking.h:
>+
> 2019-05-12  Yusuke Suzuki  <ysuzuki@apple.com>
> 
>         [JSC] Compress Watchpoint size by using enum type and Packed<> data structure
>diff --git a/Source/WTF/wtf/Platform.h b/Source/WTF/wtf/Platform.h
>index 90d9891f8919e4e6dc682ce968eb461cb9b64425..6ec24e147bdd20973a34a4d8d6412e91e0ebef5b 100644
>--- a/Source/WTF/wtf/Platform.h
>+++ b/Source/WTF/wtf/Platform.h
>@@ -1543,6 +1543,10 @@
> #define HAVE_ROUTE_SHARING_POLICY_LONG_FORM_VIDEO 1
> #endif
> 
>+#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MAX_ALLOWED < 101500
>+#define USE_REALPATH_FOR_DLOPEN_PREFLIGHT 1
>+#endif
>+
> #if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101500) || (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130000) || (PLATFORM(WATCHOS) && __WATCH_OS_VERSION_MIN_REQUIRED >= 60000) || (PLATFORM(APPLETV) && __TV_OS_VERSION_MIN_REQUIRED >= 130000)
> #define HAVE_AVPLAYER_RESOURCE_CONSERVATION_LEVEL 1
> #endif
>diff --git a/Source/WTF/wtf/cocoa/SoftLinking.h b/Source/WTF/wtf/cocoa/SoftLinking.h
>index 47fb78ad826ecc0ad84975eee03985c24f4034a6..b890ede4695cdd41f6df3c1e2b49ccb68ee822aa 100644
>--- a/Source/WTF/wtf/cocoa/SoftLinking.h
>+++ b/Source/WTF/wtf/cocoa/SoftLinking.h
>@@ -24,9 +24,10 @@
> 
> #pragma once
> 
>-#import <wtf/Assertions.h>
> #import <dlfcn.h>
> #import <objc/runtime.h>
>+#import <wtf/Assertions.h>
>+#import <wtf/FileSystem.h>
> 
> #pragma mark - Soft-link macros for use within a single source file
> 
>@@ -63,10 +64,16 @@
>         return frameworkLibrary; \
>     }
> 
>+#if USE(REALPATH_FOR_DLOPEN_PREFLIGHT)
>+#define DLOPEN_PREFLIGHT(path) dlopen_preflight(FileSystem::realPath(path##_s).utf8().data())
>+#else
>+#define DLOPEN_PREFLIGHT(path) dlopen_preflight(path)
>+#endif
>+
> #define SOFT_LINK_FRAMEWORK_OPTIONAL_PREFLIGHT(framework) \
>     static bool framework##LibraryIsAvailable() \
>     { \
>-        static bool frameworkLibraryIsAvailable = dlopen_preflight("/System/Library/Frameworks/" #framework ".framework/" #framework); \
>+        static bool frameworkLibraryIsAvailable = DLOPEN_PREFLIGHT("/System/Library/Frameworks/" #framework ".framework/" #framework); \
>         return frameworkLibraryIsAvailable; \
>     }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 197803: 369617 | 369629 | 369745 | 369763