Attachment 369757 Details for Bug 197760 – Patch

[patch] Patch

bug-197760-20190513114359.patch (text/plain), 1.59 KB, created by Geoffrey Garen on 2019-05-13 11:43:59 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Geoffrey Garen

Created: 2019-05-13 11:43:59 PDT

Size: 1.59 KB

patch

obsolete

>Index: Source/WebCore/ChangeLog
>===================================================================
>--- Source/WebCore/ChangeLog	(revision 245242)
>+++ Source/WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,15 @@
>+2019-05-13  Geoffrey Garen  <ggaren@apple.com>
>+
>+        Downgrade RELEASE_ASSERT TO RELEASE_LOG_FAULT for SQLite Class A files
>+        https://bugs.webkit.org/show_bug.cgi?id=197760
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Only makeSafeToUseMemoryMapForPath() if needed. (Fixed missing brace.)
>+
>+        * platform/sql/SQLiteDatabase.cpp:
>+        (WebCore::SQLiteDatabase::open):
>+
> 2019-05-13  Antti Koivisto  <antti@apple.com>
> 
>         REGRESSION (r245208): compositing/shared-backing/sharing-bounds-non-clipping-shared-layer.html asserts
>Index: Source/WebCore/platform/sql/SQLiteDatabase.cpp
>===================================================================
>--- Source/WebCore/platform/sql/SQLiteDatabase.cpp	(revision 245242)
>+++ Source/WebCore/platform/sql/SQLiteDatabase.cpp	(working copy)
>@@ -151,9 +151,10 @@ bool SQLiteDatabase::open(const String& 
> 
>     String shmFileName = makeString(filename, "-shm"_s);
>     if (FileSystem::fileExists(shmFileName)) {
>-        if (!FileSystem::isSafeToUseMemoryMapForPath(shmFileName))
>+        if (!FileSystem::isSafeToUseMemoryMapForPath(shmFileName)) {
>             RELEASE_LOG_FAULT(SQLDatabase, "Opened an SQLite database with a Class A -shm file. This may trigger a crash when the user locks the device. (%s)", shmFileName.latin1().data());
>             FileSystem::makeSafeToUseMemoryMapForPath(shmFileName);
>+        }
>     }
> 
>     return isOpen();

Actions: View | Formatted Diff | Diff

Attachments on bug 197760: 369530 | 369577 | 369757