Attachment 369754 Details for Bug 194437 – Patch

[patch] Patch

bug-194437-20190513113201.patch (text/plain), 3.06 KB, created by Devin Rousso on 2019-05-13 11:32:01 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Devin Rousso

Created: 2019-05-13 11:32:01 PDT

Size: 3.06 KB

patch

obsolete

>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index ea00b880adeed0b9faa473d5a57554f04d2790ce..1ff9c670ba2a0ecb2f5af21907f0bd4c2920a65c 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,14 @@
>+2019-05-13  Devin Rousso  <drousso@apple.com>
>+
>+        REGRESSION (r240644): Layout Test inspector/page/overrideSetting-ICECandidateFilteringEnabled.html is a flaky timeout
>+        https://bugs.webkit.org/show_bug.cgi?id=194437
>+        <rdar://problem/48008005>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * inspector/page/overrideSetting-ICECandidateFilteringEnabled.html:
>+        * inspector/page/overrideSetting-ICECandidateFilteringEnabled-expected.txt:
>+
> 2019-05-12  Simon Fraser  <simon.fraser@apple.com>
> 
>         REGRESSION (r245208): compositing/shared-backing/sharing-bounds-non-clipping-shared-layer.html asserts
>diff --git a/LayoutTests/inspector/page/overrideSetting-ICECandidateFilteringEnabled-expected.txt b/LayoutTests/inspector/page/overrideSetting-ICECandidateFilteringEnabled-expected.txt
>index ddefa7007eb40842c86b03d2f09b7de7a21534ac..fbafb1ac106eff9af786b4d2e62c2f9e32e53c69 100644
>--- a/LayoutTests/inspector/page/overrideSetting-ICECandidateFilteringEnabled-expected.txt
>+++ b/LayoutTests/inspector/page/overrideSetting-ICECandidateFilteringEnabled-expected.txt
>@@ -8,8 +8,4 @@ Creating data channel...
> PASS: created offer
> PASS: received ICE candidate.
> PASS: Should be able to establish a connection when filtering ice candidates.
>-Removing ICECandidateFilteringEnabled override...
>-Creating data channel...
>-PASS: created offer
>-PASS: Should not be able to establish a connection when filtering ice candidates.
> 
>diff --git a/LayoutTests/inspector/page/overrideSetting-ICECandidateFilteringEnabled.html b/LayoutTests/inspector/page/overrideSetting-ICECandidateFilteringEnabled.html
>index 4e1bc2016c006a24c27554f9ef223c35f1189d0f..bdb1ff89833a8bfaef08743bc0da86e60ee501df 100644
>--- a/LayoutTests/inspector/page/overrideSetting-ICECandidateFilteringEnabled.html
>+++ b/LayoutTests/inspector/page/overrideSetting-ICECandidateFilteringEnabled.html
>@@ -43,8 +43,6 @@ function createDataChannel() {
> 
> function test()
> {
>-    InspectorTest.debug();
>-
>     let suite = InspectorTest.createAsyncSuite("Page.overrideSetting");
> 
>     suite.addTestCase({
>@@ -59,15 +57,6 @@ function test()
>                 InspectorTest.evaluateInPage(`createDataChannel()`),
>             ])
>             InspectorTest.expectThat(overriddenResult.data.success, "Should be able to establish a connection when filtering ice candidates.");
>-
>-            InspectorTest.log("Removing ICECandidateFilteringEnabled override...");
>-            await PageAgent.overrideSetting(PageAgent.Setting.ICECandidateFilteringEnabled);
>-
>-            let [originalResult] = await Promise.all([
>-                InspectorTest.awaitEvent("DataChannel"),
>-                InspectorTest.evaluateInPage(`createDataChannel()`),
>-            ])
>-            InspectorTest.expectFalse(originalResult.data.success, "Should not be able to establish a connection when filtering ice candidates.");
>         },
>     });
>

Actions: View | Formatted Diff | Diff

Attachments on bug 194437: 363171 | 367060 | 369754